[jira] [Commented] (BIGTOP-2704) Include ODPi runtime tests option into the battery of smoke tests

["Konstantin Boudnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935344#comment-15935344 ] 

Konstantin Boudnik commented on BIGTOP-2704:
--------------------------------------------

Thank you very much for the effort!

A few comments from the initial glance at it:
- these are just some runtime tests. Shall they really be in {{odpi-runtime}} folder? Is this a vendor-specific suite?
- Perhaps {{JarInfo}} related code could be moved to iTest, if I haven't misread it. Although, this refactoring might be done in a consequent ticket
- ALc2 headers have html tags {{<p>}} and alike
- In quite a few files, Java code formatting is not Hadoop/Bigtop like. Heck, it isn't even Sun Java Style Guide like, Pease consider reformatting. Also, I see some lines of like 217 characters long or something.
- JdbcConnector has a bunch of 'odpi' prefixes hardcoded
- package names are 'odpi'. Should be fixed

There are a number of the spec tests, which aren't really the integration tests like the ones for Hive and HCat. Can we at least split this patch in two, so there's a way to give it a better review?

> Include ODPi runtime tests option into the battery of smoke tests
> -----------------------------------------------------------------
>
>                 Key: BIGTOP-2704
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2704
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: tests
>    Affects Versions: 1.2.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 1.2.0
>
>         Attachments: 0001-BIGTOP-2704.-Include-ODPi-runtime-tests-option-into-.patch
>
>
> ODPi has developed a number of tests for extra validation of Hadoop stacks. All of these tests were developed with, essentially, Bigtop as a reference implementation in mind. It seems reasonable to include those as an option into our battery of smoke tests.
> All of these tests seem to be easy to maintain and they test for reasonable assertions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)