You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/02/17 07:27:29 UTC
[GitHub] [incubator-doris] arthuryangcs opened a new pull request #8112: [fix](load) Fix InsertStmt prepareExpressions
arthuryangcs opened a new pull request #8112:
URL: https://github.com/apache/incubator-doris/pull/8112
Use queryStmt.getResultExprs() instead of queryStmt.getBaseTblResultExprs() in InsertStmt prepareExpressions func.
# Proposed changes
Issue Number: close #8111
## Problem Summary:
Use queryStmt.getResultExprs() instead of queryStmt.getBaseTblResultExprs() in InsertStmt prepareExpressions func.
## Checklist(Required)
1. Does it affect the original behavior: Yes
2. Has unit tests been added:Yes
3. Has document been added or modified: No
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] arthuryangcs commented on pull request #8112: [fix](load) Fix InsertStmt prepareExpressions
Posted by GitBox <gi...@apache.org>.
arthuryangcs commented on pull request #8112:
URL: https://github.com/apache/incubator-doris/pull/8112#issuecomment-1048406083
@weizuo93 PTAL, THX~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8112: [fix](load) Fix InsertStmt prepareExpressions
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #8112:
URL: https://github.com/apache/incubator-doris/pull/8112#discussion_r812613422
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/profile/PlanTreeBuilder.java
##########
@@ -56,7 +56,11 @@ private void buildFragmentPlans() {
PlanTreeNode sinkNode = null;
if (sink != null) {
StringBuilder sb = new StringBuilder();
- sb.append("[").append(sink.getExchNodeId().asInt()).append(": ").append(sink.getClass().getSimpleName()).append("]");
+ if(sink.getExchNodeId() != null) {
Review comment:
Pay attention to the code format ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #8112: [fix](load) Fix InsertStmt prepareExpressions
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #8112:
URL: https://github.com/apache/incubator-doris/pull/8112#discussion_r812536284
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/InsertStmt.java
##########
@@ -667,7 +667,7 @@ private void analyzePlanHints(Analyzer analyzer) throws AnalysisException {
}
public void prepareExpressions() throws UserException {
- List<Expr> selectList = Expr.cloneList(queryStmt.getBaseTblResultExprs());
+ List<Expr> selectList = Expr.cloneList(queryStmt.getResultExprs());
Review comment:
can you add some comment to explain why ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] arthuryangcs commented on a change in pull request #8112: [fix](load) Fix InsertStmt prepareExpressions
Posted by GitBox <gi...@apache.org>.
arthuryangcs commented on a change in pull request #8112:
URL: https://github.com/apache/incubator-doris/pull/8112#discussion_r812628568
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/profile/PlanTreeBuilder.java
##########
@@ -56,7 +56,11 @@ private void buildFragmentPlans() {
PlanTreeNode sinkNode = null;
if (sink != null) {
StringBuilder sb = new StringBuilder();
- sb.append("[").append(sink.getExchNodeId().asInt()).append(": ").append(sink.getClass().getSimpleName()).append("]");
+ if(sink.getExchNodeId() != null) {
Review comment:
done, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8112: [fix](load) Fix InsertStmt prepareExpressions
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #8112:
URL: https://github.com/apache/incubator-doris/pull/8112#discussion_r812629535
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/profile/PlanTreeBuilder.java
##########
@@ -17,6 +17,7 @@
package org.apache.doris.common.profile;
+import com.clearspring.analytics.util.Lists;
Review comment:
Error import ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] arthuryangcs commented on a change in pull request #8112: [fix](load) Fix InsertStmt prepareExpressions
Posted by GitBox <gi...@apache.org>.
arthuryangcs commented on a change in pull request #8112:
URL: https://github.com/apache/incubator-doris/pull/8112#discussion_r812630162
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/profile/PlanTreeBuilder.java
##########
@@ -17,6 +17,7 @@
package org.apache.doris.common.profile;
+import com.clearspring.analytics.util.Lists;
Review comment:
fixed~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #8112: [fix](load) Fix InsertStmt prepareExpressions
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #8112:
URL: https://github.com/apache/incubator-doris/pull/8112#issuecomment-1048524830
Please waiting for the P0 test and unit test ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8112: [fix](load) Fix InsertStmt prepareExpressions
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #8112:
URL: https://github.com/apache/incubator-doris/pull/8112#discussion_r812614464
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/InsertStmt.java
##########
@@ -667,7 +667,7 @@ private void analyzePlanHints(Analyzer analyzer) throws AnalysisException {
}
public void prepareExpressions() throws UserException {
- List<Expr> selectList = Expr.cloneList(queryStmt.getBaseTblResultExprs());
+ List<Expr> selectList = Expr.cloneList(queryStmt.getResultExprs());
Review comment:
The ```ResultExprs``` is the finally expr of querystmt.
So, this change is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] arthuryangcs commented on a change in pull request #8112: [fix](load) Fix InsertStmt prepareExpressions
Posted by GitBox <gi...@apache.org>.
arthuryangcs commented on a change in pull request #8112:
URL: https://github.com/apache/incubator-doris/pull/8112#discussion_r812590295
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/InsertStmt.java
##########
@@ -667,7 +667,7 @@ private void analyzePlanHints(Analyzer analyzer) throws AnalysisException {
}
public void prepareExpressions() throws UserException {
- List<Expr> selectList = Expr.cloneList(queryStmt.getBaseTblResultExprs());
+ List<Expr> selectList = Expr.cloneList(queryStmt.getResultExprs());
Review comment:
I think that generating InserStmt's resultExprs from queryStmt's resultExprs is more reasonable, or maybe I make a mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8112: [fix](load) Fix InsertStmt prepareExpressions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8112:
URL: https://github.com/apache/incubator-doris/pull/8112#issuecomment-1048524822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] arthuryangcs commented on a change in pull request #8112: [fix](load) Fix InsertStmt prepareExpressions
Posted by GitBox <gi...@apache.org>.
arthuryangcs commented on a change in pull request #8112:
URL: https://github.com/apache/incubator-doris/pull/8112#discussion_r812588806
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/InsertStmt.java
##########
@@ -667,7 +667,7 @@ private void analyzePlanHints(Analyzer analyzer) throws AnalysisException {
}
public void prepareExpressions() throws UserException {
- List<Expr> selectList = Expr.cloneList(queryStmt.getBaseTblResultExprs());
+ List<Expr> selectList = Expr.cloneList(queryStmt.getResultExprs());
Review comment:
I'm not sure this is right, but this can solve the issues :)
I don't know why using getBaseTblResultExprs rather than getResultExprs there, are there some other considerations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8112: [fix](load) Fix InsertStmt prepareExpressions
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #8112:
URL: https://github.com/apache/incubator-doris/pull/8112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org