You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2015/02/19 15:21:37 UTC
[GitHub] spark pull request: [SPARK-5907][SQL] Selected column from DataFra...
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/4691
[SPARK-5907][SQL] Selected column from DataFrame should not re-analyze logical plan
Currently, selecting a column from DataFrame wraps the original logical plan with a Project. As the column is used, the logical plan will be analyzed again. For some query plan, re-analyzing would side-effect that increases expression id. So when accessing the column, column's expr and its analyzed plan will point to different expressions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 not_reanalyzed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4691.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4691
----
commit 7c8a2ed529843092c92ca55b8f29bc6094dd2105
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2015-02-19T14:18:05Z
Selected column from DataFrame should not re-analyze logical plan.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5907][SQL] Selected column from DataFra...
Posted by viirya <gi...@git.apache.org>.
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/4691
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5907][SQL] Selected column from DataFra...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/4691#issuecomment-75091023
This issue has to be considered with #4692 together.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5907][SQL] Selected column from DataFra...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4691#issuecomment-75065920
[Test build #27721 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27721/consoleFull) for PR 4691 at commit [`7c8a2ed`](https://github.com/apache/spark/commit/7c8a2ed529843092c92ca55b8f29bc6094dd2105).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5907][SQL] Selected column from DataFra...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4691#issuecomment-75059109
[Test build #27721 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27721/consoleFull) for PR 4691 at commit [`7c8a2ed`](https://github.com/apache/spark/commit/7c8a2ed529843092c92ca55b8f29bc6094dd2105).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5907][SQL] Selected column from DataFra...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4691#issuecomment-75065929
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27721/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org