You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/22 14:39:29 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4338: server: check guest os preference of last host when start a vm
ustcweizhou opened a new pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338
## Description
<!--- Describe your changes in detail -->
If vm has last host_id specified, cloudstack will try to start vm on it at first.
However, host tag is checked, but guest os preference is not checked.
for new vm, it will be deployed to the preferred host as we expect.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
Fixes: https://github.com/apache/cloudstack/issues/3554#issuecomment-564001531
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338#issuecomment-698165087
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338#issuecomment-698165087
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338#issuecomment-698247764
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338#issuecomment-698583879
<b>Trillian test result (tid-2846)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46460 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4338-t2846-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 257.66 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 341.11 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 482.25 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338#issuecomment-698165411
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338#issuecomment-697939280
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338#issuecomment-698165411
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338#issuecomment-697953299
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338#issuecomment-698247764
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338#discussion_r493686431
##########
File path: server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
##########
@@ -489,8 +487,6 @@ public DeployDestination planDeployment(VirtualMachineProfile vmProfile, Deploym
} else {
s_logger.debug("The last host of this VM does not have enough capacity");
}
- } else {
Review comment:
@ravening it is moved to method checkVmProfileAndHost line 573
https://github.com/apache/cloudstack/pull/4338/files#diff-33d8e6144eebe797af78210131747498R573
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338#issuecomment-697939482
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338#discussion_r493686431
##########
File path: server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
##########
@@ -489,8 +487,6 @@ public DeployDestination planDeployment(VirtualMachineProfile vmProfile, Deploym
} else {
s_logger.debug("The last host of this VM does not have enough capacity");
}
- } else {
Review comment:
@ravening it is moved to method checkVmProfileAndHost
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4338: server: check guest os preference of last host when start a vm
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #4338:
URL: https://github.com/apache/cloudstack/pull/4338#discussion_r493625017
##########
File path: server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
##########
@@ -489,8 +487,6 @@ public DeployDestination planDeployment(VirtualMachineProfile vmProfile, Deploym
} else {
s_logger.debug("The last host of this VM does not have enough capacity");
}
- } else {
Review comment:
Any reason to delete this log? Better to display if either tags or the guest os preference mismatches right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org