You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/06/19 16:16:07 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #1126: Convert SparkTableUtil.scala to SparkTableUtil.java

rdblue commented on a change in pull request #1126:
URL: https://github.com/apache/iceberg/pull/1126#discussion_r442930254



##########
File path: build.gradle
##########
@@ -79,8 +79,8 @@ subprojects {
 
     compileClasspath {
       // do not exclude Guava so the bundle project can reference classes.
-      // the Spark module is also excluded because this breaks the Scala compiler
-      if (project.name != 'iceberg-bundled-guava' && project.name != 'iceberg-spark' && project.name != 'iceberg-spark2') {
+      // the Spark2 module is also excluded because this breaks the Scala compiler
+      if (project.name != 'iceberg-bundled-guava' && project.name != 'iceberg-spark2') {

Review comment:
       The spark2 module was included so that the relocated Scala code would work. If we no longer have any Scala, then we don't need this for spark2 either.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org