You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/13 14:11:25 UTC
[GitHub] [superset] AAfghahi commented on a change in pull request #15598: feat: Gsheet adding sheets component
AAfghahi commented on a change in pull request #15598:
URL: https://github.com/apache/superset/pull/15598#discussion_r668802521
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -115,78 +121,90 @@ const CredentialsInfo = ({
placeholder="Paste content of service credentials JSON file here"
/>
<span className="label-paste">
- {t('Copy and paste the entire service account .json file here')}
+ {t(
+ 'Copy and paste the entire service account .json file here to enable connection',
+ )}
</span>
</div>
) : (
- <div
- className="input-container"
- css={(theme: SupersetTheme) => infoTooltip(theme)}
- >
- <div css={{ display: 'flex', alignItems: 'center' }}>
- <FormLabel required>{t('Upload Credentials')}</FormLabel>
- <InfoTooltip
- tooltip={t(
- 'Use the JSON file you automatically downloaded when creating your service account in Google BigQuery.',
- )}
- viewBox="0 0 24 24"
- />
- </div>
-
- {!fileToUpload && (
- <Button
- className="input-upload-btn"
- onClick={() => document?.getElementById('selectedFile')?.click()}
- >
- {t('Choose File')}
- </Button>
- )}
- {fileToUpload && (
- <div className="input-upload-current">
- {fileToUpload}
- <DeleteFilled
- onClick={() => {
- setFileToUpload(null);
- changeMethods.onParametersChange({
- target: {
- name: 'credentials_info',
- value: '',
- },
- });
- }}
+ db?.engine !== 'gsheets' && (
+ <div
+ className="input-container"
+ css={(theme: SupersetTheme) => infoTooltip(theme)}
+ >
+ <div css={{ display: 'flex', alignItems: 'center' }}>
+ <FormLabel required>{t('Upload Credentials')}</FormLabel>
+ <InfoTooltip
+ tooltip={t(
+ 'Use the JSON file you automatically downloaded when creating your service account in Google BigQuery.',
+ )}
+ viewBox="0 0 24 24"
/>
</div>
- )}
-
- <input
- id="selectedFile"
- className="input-upload"
- type="file"
- onChange={async event => {
- let file;
- if (event.target.files) {
- file = event.target.files[0];
- }
- setFileToUpload(file?.name);
- changeMethods.onParametersChange({
- target: {
- type: null,
- name: 'credentials_info',
- value: await file?.text(),
- checked: false,
- },
- });
- (document.getElementById(
- 'selectedFile',
- ) as HTMLInputElement).value = null as any;
- }}
- />
- </div>
+ )
+ {!fileToUpload && (
+ <Button
+ className="input-upload-btn"
+ onClick={() =>
+ document?.getElementById('selectedFile')?.click()
+ }
+ >
+ {t('Choose File')}
+ </Button>
+ )}
+ {fileToUpload && (
+ <div className="input-upload-current">
+ {fileToUpload}
+ <DeleteFilled
+ onClick={() => {
+ setFileToUpload(null);
+ changeMethods.onParametersChange({
+ target: {
+ name: 'credentials_info',
+ value: '',
+ },
+ });
+ }}
+ />
+ </div>
+ )}
+ <input
+ id="selectedFile"
+ className="input-upload"
+ type="file"
+ onChange={async event => {
+ let file;
+ if (event.target.files) {
+ file = event.target.files[0];
+ }
+ setFileToUpload(file?.name);
+ changeMethods.onParametersChange({
+ target: {
+ type: null,
+ name: 'credentials_info',
+ value: await file?.text(),
+ checked: false,
+ },
+ });
+ (document.getElementById(
+ 'selectedFile',
+ ) as HTMLInputElement).value = null as any;
+ }}
+ />
+ </div>
+ )
)}
</CredentialInfoForm>
);
};
+const TableCatalog = ({
+ changeMethods,
+ isEditMode,
+ db,
+ editNewDb,
+}: FieldPropTypes) => <>hello! {db?.engine}</>;
Review comment:
yeah this was where i ran out of time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org