You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Fine0830 (via GitHub)" <gi...@apache.org> on 2023/05/10 06:37:09 UTC
[GitHub] [skywalking-grafana-plugins] Fine0830 opened a new pull request, #1: build(ci): update yaml for checking license
Fine0830 opened a new pull request, #1:
URL: https://github.com/apache/skywalking-grafana-plugins/pull/1
Update yaml for checking license.
Signed-off-by: Qiuxia Fan <qi...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-grafana-plugins] wu-sheng commented on a diff in pull request #1: build(ci): update yaml for checking license
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #1:
URL: https://github.com/apache/skywalking-grafana-plugins/pull/1#discussion_r1189507622
##########
.github/workflows/nodejs.yml:
##########
@@ -60,3 +68,12 @@ jobs:
- name: Stop grafana docker
run: docker-compose down
+ env:
+ CI: true
+ build:
+ runs-on: ubuntu-latest
+ timeout-minutes: 90
+ needs: [yarn]
Review Comment:
```suggestion
needs: [yarn, check-license]
```
Do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-grafana-plugins] wu-sheng merged pull request #1: build(ci): update yaml for checking license
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #1:
URL: https://github.com/apache/skywalking-grafana-plugins/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-grafana-plugins] Fine0830 commented on pull request #1: build(ci): update yaml for checking license
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #1:
URL: https://github.com/apache/skywalking-grafana-plugins/pull/1#issuecomment-1541518359
> You need a named CI task to depend other CI tasks.
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-grafana-plugins] wu-sheng commented on pull request #1: build(ci): update yaml for checking license
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #1:
URL: https://github.com/apache/skywalking-grafana-plugins/pull/1#issuecomment-1541504992
You need a named CI task to depend other CI tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org