You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by hegdean <gi...@git.apache.org> on 2015/12/17 01:05:51 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
GitHub user hegdean opened a pull request:
https://github.com/apache/incubator-trafodion/pull/231
[TRAFODION-1680] Dcs needs to provide support for HA on AWS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hegdean/incubator-trafodion wrk-brnch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #231
----
commit 1f0d872bd11262fbd5b66b3e11d3cab059faf050
Author: Anuradha Hegde <he...@adev04.esgyn.com>
Date: 2015-12-14T03:33:33Z
Floating IP support for AWS cluster
commit f9ef790dc6cc35fc2aece7771feb92321f4f6fdb
Author: Anuradha Hegde <an...@esgyn.com>
Date: 2015-12-14T03:36:23Z
Merge branch 'master' into wrk-brnch
commit fafc88ff812ffc23fd88217dc65d78d234e76198
Author: Anuradha Hegde <an...@esgyn.com>
Date: 2015-12-15T02:02:26Z
Merge branch 'master' into wrk-brnch
commit 68157d51fd1dbbbff562b2564f664b7783372c12
Author: Anuradha Hegde <an...@esgyn.com>
Date: 2015-12-15T18:32:23Z
Additional changes for floating ip.
Support to start dcsmaster on remote node
commit c14887c5940c8fa99a35138cd984a3e2a5e4ab3c
Author: Anuradha Hegde <an...@esgyn.com>
Date: 2015-12-15T18:34:09Z
Merge branch 'master' into wrk-brnch
commit 34ff7b309b58e76f3461c0519940f2e3463d8d13
Author: Anuradha Hegde <an...@esgyn.com>
Date: 2015-12-15T18:52:32Z
Merge branch 'master' into wrk-brnch
commit bc691879b0012888e12ee2be9d6eb948359e5f30
Author: Anuradha Hegde <an...@esgyn.com>
Date: 2015-12-16T18:15:30Z
Improved display for dcscheck script
additional bug fixes
commit cbcde79ea87bae975a3a1c18faa17223d80b1a2d
Author: Anuradha Hegde <an...@esgyn.com>
Date: 2015-12-16T23:42:33Z
fixes
commit 254447922f3df5aaa411ca7c5ffff0b6528265c5
Author: Anuradha Hegde <an...@esgyn.com>
Date: 2015-12-16T23:49:02Z
added the missing quotes
commit 718880c8f0e8cb08fb2fe29ab456f8cdf33fa9cd
Author: Anuradha Hegde <an...@esgyn.com>
Date: 2015-12-16T23:58:41Z
Changed name to lowercase for MXOSRVR to match the process name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Posted by hegdean <gi...@git.apache.org>.
Github user hegdean commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/231#discussion_r47987698
--- Diff: install/installer/setup_ssh_key ---
@@ -0,0 +1,27 @@
+#!/bin/bash
--- End diff --
This has to be an empty file that needs to exist and will be updated during installation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Posted by hegdean <gi...@git.apache.org>.
Github user hegdean commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/231#discussion_r48060125
--- Diff: core/sqf/sql/scripts/cleanlogs ---
@@ -0,0 +1,92 @@
+#!/bin/bash
+#
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+# This script cleans up the log files of various components
+if [ -e $SQ_PDSH ]; then
+ L_PDSH="/usr/bin/pdsh $MY_NODES "
+else
+ L_PDSH=
+fi
+
+function usage() {
+ prog=`basename $0`
+ echo ""
+ echo "$prog { all | dcs | rest | core }"
+ echo " all --- Remove files from core, dcs and rest logs folder"
+ echo " dcs --- Remove files from $DCS_INSTALL_DIR/logs folder"
+ echo " rest --- Remove files from $REST_INSTALL_DIR/logs folder"
+ echo " core --- Remove log files residing in $MY_SQROOT/logs folder"
--- End diff --
This will be used only during troubleshooting not otherwise
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Posted by kevinxu021 <gi...@git.apache.org>.
Github user kevinxu021 commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/231#discussion_r47986963
--- Diff: install/installer/setup_ssh_key ---
@@ -0,0 +1,27 @@
+#!/bin/bash
--- End diff --
dcs/conf/master seems to be an empty file. is that possible to remove it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Posted by kevinxu021 <gi...@git.apache.org>.
Github user kevinxu021 commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/231#discussion_r47984062
--- Diff: core/sqf/sql/scripts/cleanlogs ---
@@ -0,0 +1,92 @@
+#!/bin/bash
+#
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+# This script cleans up the log files of various components
+if [ -e $SQ_PDSH ]; then
+ L_PDSH="/usr/bin/pdsh $MY_NODES "
+else
+ L_PDSH=
+fi
+
+function usage() {
+ prog=`basename $0`
+ echo ""
+ echo "$prog { all | dcs | rest | core }"
+ echo " all --- Remove files from core, dcs and rest logs folder"
+ echo " dcs --- Remove files from $DCS_INSTALL_DIR/logs folder"
+ echo " rest --- Remove files from $REST_INSTALL_DIR/logs folder"
+ echo " core --- Remove log files residing in $MY_SQROOT/logs folder"
--- End diff --
dcs and rest are component name. Could you please list out what kinds of logs included in core? For DEV, it's very good, but for production it's dangerous that it may lost lots of important info. A little confused that the logs has rotation rules why to clear them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Posted by kevinxu021 <gi...@git.apache.org>.
Github user kevinxu021 commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/231#discussion_r47985038
--- Diff: core/sqf/sql/scripts/cleanlogs ---
@@ -0,0 +1,92 @@
+#!/bin/bash
+#
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+# This script cleans up the log files of various components
+if [ -e $SQ_PDSH ]; then
+ L_PDSH="/usr/bin/pdsh $MY_NODES "
+else
+ L_PDSH=
+fi
+
+function usage() {
+ prog=`basename $0`
+ echo ""
+ echo "$prog { all | dcs | rest | core }"
+ echo " all --- Remove files from core, dcs and rest logs folder"
+ echo " dcs --- Remove files from $DCS_INSTALL_DIR/logs folder"
+ echo " rest --- Remove files from $REST_INSTALL_DIR/logs folder"
+ echo " core --- Remove log files residing in $MY_SQROOT/logs folder"
--- End diff --
it's might be helpful that save them before remove, or give users some tips and tell them the logs will be removed. if they insist on, go ahead to remove them. yes, it's a utility, but some users might use it, right? we know what they are in MY_SQROOT/logs folder, but the users may not, so those info should be included. otherwise, users may make mistakes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Posted by kevinxu021 <gi...@git.apache.org>.
Github user kevinxu021 commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/231#discussion_r47987848
--- Diff: install/installer/setup_ssh_key ---
@@ -0,0 +1,27 @@
+#!/bin/bash
--- End diff --
curious, nothing in it. it could be created during installation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Posted by kevinxu021 <gi...@git.apache.org>.
Github user kevinxu021 commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/231#discussion_r47983358
--- Diff: RAT_README.txt ---
@@ -60,6 +60,7 @@ $MY_SQROOT/../sql/bin/SqlciErrors.txt
dcs/conf/servers
dcs/conf/backup-masters
+dcs/conf/master
: Apache Trafodion DCS default configuration file
-> configuration file do not handle comments
--- End diff --
Please describe those files separately. it's not very clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Posted by hegdean <gi...@git.apache.org>.
Github user hegdean commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/231#discussion_r48059956
--- Diff: RAT_README.txt ---
@@ -60,6 +60,7 @@ $MY_SQROOT/../sql/bin/SqlciErrors.txt
dcs/conf/servers
dcs/conf/backup-masters
+dcs/conf/master
: Apache Trafodion DCS default configuration file
-> configuration file do not handle comments
--- End diff --
This is not documentation but a short description for each component for list of files that excludes the copyright information as mentioned in the initial section of the this file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Posted by hegdean <gi...@git.apache.org>.
Github user hegdean commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/231#discussion_r48060646
--- Diff: install/installer/setup_ssh_key ---
@@ -0,0 +1,27 @@
+#!/bin/bash
--- End diff --
This is is similar to our backup-masters file which is also empty and does no harm but it helps users to know that they can modify this file if they require DcsMaster to start on a specific node. Dcs documentation will be updated in the subsequent PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Posted by hegdean <gi...@git.apache.org>.
Github user hegdean commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/231#discussion_r47984639
--- Diff: RAT_README.txt ---
@@ -60,6 +60,7 @@ $MY_SQROOT/../sql/bin/SqlciErrors.txt
dcs/conf/servers
dcs/conf/backup-masters
+dcs/conf/master
: Apache Trafodion DCS default configuration file
-> configuration file do not handle comments
--- End diff --
dcs/conf/master is another configuration file which contains the hostname.. It is just like backup-masters file and as described in the comments it does not handle comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Posted by kevinxu021 <gi...@git.apache.org>.
Github user kevinxu021 commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/231#discussion_r47987721
--- Diff: RAT_README.txt ---
@@ -60,6 +60,7 @@ $MY_SQROOT/../sql/bin/SqlciErrors.txt
dcs/conf/servers
dcs/conf/backup-masters
+dcs/conf/master
: Apache Trafodion DCS default configuration file
-> configuration file do not handle comments
--- End diff --
could you please list out what those three files for separately. "Apache Trafodion DCS default configuration file" is not clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1680] Dcs needs to pr...
Posted by hegdean <gi...@git.apache.org>.
Github user hegdean commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/231#discussion_r47984503
--- Diff: core/sqf/sql/scripts/cleanlogs ---
@@ -0,0 +1,92 @@
+#!/bin/bash
+#
+# @@@ START COPYRIGHT @@@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# @@@ END COPYRIGHT @@@
+
+# This script cleans up the log files of various components
+if [ -e $SQ_PDSH ]; then
+ L_PDSH="/usr/bin/pdsh $MY_NODES "
+else
+ L_PDSH=
+fi
+
+function usage() {
+ prog=`basename $0`
+ echo ""
+ echo "$prog { all | dcs | rest | core }"
+ echo " all --- Remove files from core, dcs and rest logs folder"
+ echo " dcs --- Remove files from $DCS_INSTALL_DIR/logs folder"
+ echo " rest --- Remove files from $REST_INSTALL_DIR/logs folder"
+ echo " core --- Remove log files residing in $MY_SQROOT/logs folder"
--- End diff --
cleanlogs script is only a helpful utility. This cleanlogs script is not invoked by any other script and used only on demand on need basis. The logs for core are all the log files that reside in MY_SQROOT/logs folder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---