You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2024/06/02 12:16:28 UTC
[PR] [fix](ub) fix some ub error [doris]
Mryange opened a new pull request, #35769:
URL: https://github.com/apache/doris/pull/35769
## Proposed changes
test pr in this https://github.com/apache/doris/pull/35177
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ub) fix some ub error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35769:
URL: https://github.com/apache/doris/pull/35769#issuecomment-2143834563
TeamCity be ut coverage result:
Function Coverage: 36.26% (9233/25460)
Line Coverage: 27.60% (75677/274213)
Region Coverage: 26.81% (39177/146108)
Branch Coverage: 23.53% (19846/84338)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3073ae37bd7d63317457da7a448fbc48ddcbdcd8_3073ae37bd7d63317457da7a448fbc48ddcbdcd8/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ub) fix some ub error [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on code in PR #35769:
URL: https://github.com/apache/doris/pull/35769#discussion_r1650032436
##########
be/src/exprs/hybrid_set.h:
##########
@@ -668,7 +668,7 @@ class StringValueSet : public HybridSetBase {
const doris::vectorized::NullMap* null_map,
doris::vectorized::ColumnUInt8::Container& results) {
const auto& col = assert_cast<const doris::vectorized::ColumnString&>(column);
- const uint32_t* __restrict offset = col.get_offsets().data();
+ const auto& offset = col.get_offsets();
Review Comment:
1. why this modificial works?
2. may be we can apply the change to other places like L672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ub) fix some ub error [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #35769:
URL: https://github.com/apache/doris/pull/35769#issuecomment-2143826387
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ub) fix some ub error [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #35769:
URL: https://github.com/apache/doris/pull/35769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ub) fix some ub error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35769:
URL: https://github.com/apache/doris/pull/35769#issuecomment-2143827362
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ub) fix some ub error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35769:
URL: https://github.com/apache/doris/pull/35769#issuecomment-2143856458
<details>
<summary>TPC-H: <b>Total hot run time: 40349 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3073ae37bd7d63317457da7a448fbc48ddcbdcd8, data reload: false
------ Round 1 ----------------------------------
q1 18898 4534 4410 4410
q2 2646 198 206 198
q3 11198 1150 1231 1150
q4 11106 822 909 822
q5 7831 2873 2671 2671
q6 221 138 133 133
q7 970 585 586 585
q8 9205 2073 2104 2073
q9 8918 6473 6479 6473
q10 9017 3726 3732 3726
q11 460 253 246 246
q12 405 233 223 223
q13 17846 2989 2975 2975
q14 279 224 219 219
q15 514 473 477 473
q16 527 387 387 387
q17 975 638 710 638
q18 8046 7587 7433 7433
q19 7619 1570 1483 1483
q20 690 316 314 314
q21 4941 3379 3912 3379
q22 391 338 342 338
Total cold run time: 122703 ms
Total hot run time: 40349 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4379 4256 4247 4247
q2 383 280 279 279
q3 3018 2733 2751 2733
q4 1926 1631 1588 1588
q5 5267 5323 5321 5321
q6 215 128 128 128
q7 2144 1712 1761 1712
q8 3241 3358 3359 3358
q9 8418 8354 8308 8308
q10 3913 3672 3645 3645
q11 581 491 512 491
q12 761 611 601 601
q13 17732 2965 2965 2965
q14 291 275 257 257
q15 524 480 481 480
q16 506 422 429 422
q17 1790 1480 1508 1480
q18 7604 7444 7547 7444
q19 1704 1627 1617 1617
q20 2001 1805 1788 1788
q21 4943 4808 4771 4771
q22 622 554 534 534
Total cold run time: 71963 ms
Total hot run time: 54169 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ub) fix some ub error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35769:
URL: https://github.com/apache/doris/pull/35769#issuecomment-2143861607
<details>
<summary>ClickBench: <b>Total hot run time: 30.63 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3073ae37bd7d63317457da7a448fbc48ddcbdcd8, data reload: false
query1 0.04 0.03 0.03
query2 0.08 0.03 0.04
query3 0.23 0.06 0.05
query4 1.68 0.09 0.10
query5 0.49 0.49 0.49
query6 1.12 0.73 0.73
query7 0.02 0.01 0.02
query8 0.05 0.04 0.04
query9 0.54 0.48 0.48
query10 0.54 0.55 0.55
query11 0.15 0.11 0.11
query12 0.14 0.11 0.11
query13 0.58 0.58 0.59
query14 0.78 0.78 0.78
query15 0.82 0.80 0.81
query16 0.38 0.37 0.36
query17 0.99 1.05 1.04
query18 0.23 0.25 0.24
query19 1.74 1.71 1.79
query20 0.02 0.01 0.01
query21 15.51 0.67 0.64
query22 4.51 6.13 1.97
query23 18.21 1.29 1.16
query24 1.52 0.29 0.24
query25 0.14 0.08 0.08
query26 0.25 0.17 0.17
query27 0.08 0.09 0.08
query28 13.43 1.02 1.00
query29 12.99 3.37 3.30
query30 0.24 0.05 0.06
query31 2.88 0.39 0.39
query32 3.27 0.48 0.48
query33 2.90 2.91 2.93
query34 17.28 4.45 4.40
query35 4.46 4.47 4.50
query36 0.65 0.47 0.46
query37 0.17 0.16 0.17
query38 0.16 0.15 0.14
query39 0.04 0.03 0.03
query40 0.17 0.14 0.13
query41 0.10 0.05 0.04
query42 0.06 0.05 0.06
query43 0.04 0.04 0.05
Total cold run time: 109.68 s
Total hot run time: 30.63 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ub) fix some ub error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35769:
URL: https://github.com/apache/doris/pull/35769#issuecomment-2144205192
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ub) fix some ub error [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on code in PR #35769:
URL: https://github.com/apache/doris/pull/35769#discussion_r1650032436
##########
be/src/exprs/hybrid_set.h:
##########
@@ -668,7 +668,7 @@ class StringValueSet : public HybridSetBase {
const doris::vectorized::NullMap* null_map,
doris::vectorized::ColumnUInt8::Container& results) {
const auto& col = assert_cast<const doris::vectorized::ColumnString&>(column);
- const uint32_t* __restrict offset = col.get_offsets().data();
+ const auto& offset = col.get_offsets();
Review Comment:
1. why does this modification work?
2. may be we can apply the change to other places like L672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ub) fix some ub error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35769:
URL: https://github.com/apache/doris/pull/35769#issuecomment-2143859936
<details>
<summary>TPC-DS: <b>Total hot run time: 170459 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3073ae37bd7d63317457da7a448fbc48ddcbdcd8, data reload: false
query1 942 384 365 365
query2 6464 2476 2309 2309
query3 6657 206 212 206
query4 19516 17130 17255 17130
query5 4147 442 443 442
query6 252 158 149 149
query7 4586 314 299 299
query8 340 292 288 288
query9 8540 2374 2359 2359
query10 451 298 274 274
query11 10708 10099 10144 10099
query12 138 93 88 88
query13 1652 374 372 372
query14 10271 7487 7392 7392
query15 249 189 183 183
query16 7956 262 258 258
query17 1845 526 505 505
query18 2003 270 270 270
query19 198 147 147 147
query20 91 86 85 85
query21 208 134 140 134
query22 4221 4212 4236 4212
query23 33745 32861 33275 32861
query24 11912 2866 2809 2809
query25 623 358 364 358
query26 1691 151 162 151
query27 2982 313 330 313
query28 7521 2070 2065 2065
query29 1032 619 584 584
query30 289 152 151 151
query31 979 754 740 740
query32 93 52 53 52
query33 765 289 274 274
query34 983 476 487 476
query35 741 614 606 606
query36 1126 972 958 958
query37 150 66 67 66
query38 2860 2728 2745 2728
query39 846 796 783 783
query40 289 122 123 122
query41 53 51 53 51
query42 121 93 97 93
query43 614 557 549 549
query44 1209 742 754 742
query45 200 160 172 160
query46 1079 729 747 729
query47 1875 1756 1786 1756
query48 360 296 296 296
query49 1143 395 409 395
query50 786 382 390 382
query51 6833 6614 6628 6614
query52 100 92 96 92
query53 355 282 279 279
query54 1042 450 478 450
query55 70 70 73 70
query56 273 255 251 251
query57 1140 1056 1013 1013
query58 258 250 249 249
query59 3554 3490 3428 3428
query60 284 278 296 278
query61 92 84 86 84
query62 652 447 445 445
query63 318 285 286 285
query64 9926 2206 1737 1737
query65 3158 3108 3081 3081
query66 1357 327 327 327
query67 15398 14877 14891 14877
query68 4594 539 541 539
query69 454 306 309 306
query70 1127 1183 1089 1089
query71 396 299 282 282
query72 7175 5362 2758 2758
query73 744 322 325 322
query74 5970 5539 5513 5513
query75 3372 2633 2664 2633
query76 2698 936 897 897
query77 431 291 292 291
query78 10360 9887 9831 9831
query79 2723 515 503 503
query80 1134 462 454 454
query81 577 222 222 222
query82 825 102 99 99
query83 233 171 170 170
query84 245 86 85 85
query85 1540 280 256 256
query86 497 283 318 283
query87 3252 3101 3089 3089
query88 4092 2447 2442 2442
query89 537 384 387 384
query90 1753 185 183 183
query91 119 100 96 96
query92 69 47 50 47
query93 1819 520 504 504
query94 1249 179 180 179
query95 401 304 311 304
query96 589 272 272 272
query97 3199 3055 3004 3004
query98 238 232 211 211
query99 1281 857 835 835
Total cold run time: 276005 ms
Total hot run time: 170459 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ub) fix some ub error [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35769:
URL: https://github.com/apache/doris/pull/35769#issuecomment-2143824954
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ub) fix some ub error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35769:
URL: https://github.com/apache/doris/pull/35769#issuecomment-2144205223
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org