You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by keith-turner <gi...@git.apache.org> on 2016/09/20 20:21:36 UTC
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
GitHub user keith-turner opened a pull request:
https://github.com/apache/incubator-fluo-website/pull/18
turned quickstart into fluo tour
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keith-turner/incubator-fluo-website fluo-tour-init
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fluo-website/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit defc095300f266fe942a14481ce0b06dc7b7d717
Author: Keith Turner <ke...@deenlo.com>
Date: 2016-09-20T19:31:59Z
turned quickstart into fluo tour
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79884981
--- Diff: src/main/java/ft/Main.java ---
@@ -0,0 +1,44 @@
+package ft;
+
+import java.io.File;
+import java.nio.file.Files;
+
+// Normaly using * with imports is a bad practice, however in this case it makes experimenting with
+// Fluo easier.
+import org.apache.fluo.api.client.*;
+import org.apache.fluo.api.config.*;
+import org.apache.fluo.api.data.*;
+import org.apache.fluo.api.mini.MiniFluo;
+import org.apache.fluo.api.observer.*;
+
+public class Main {
+ public static void main(String[] args) throws Exception {
+
+ String tmpDir = Files.createTempDirectory(new File("target").toPath(), "mini").toString();
--- End diff --
I don't see a method on Paths to create a tmp dir. I am using Files and not File.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79885237
--- Diff: src/main/java/ft/Main.java ---
@@ -0,0 +1,44 @@
+package ft;
+
+import java.io.File;
+import java.nio.file.Files;
+
+// Normaly using * with imports is a bad practice, however in this case it makes experimenting with
+// Fluo easier.
+import org.apache.fluo.api.client.*;
+import org.apache.fluo.api.config.*;
+import org.apache.fluo.api.data.*;
+import org.apache.fluo.api.mini.MiniFluo;
+import org.apache.fluo.api.observer.*;
+
+public class Main {
+ public static void main(String[] args) throws Exception {
+
+ String tmpDir = Files.createTempDirectory(new File("target").toPath(), "mini").toString();
+ // System.out.println("tmp dir : "+tmpDir);
--- End diff --
I left it there commented out in case a user had a problem. I found it annoying to always print it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79886585
--- Diff: src/main/java/ft/Main.java ---
@@ -0,0 +1,44 @@
+package ft;
+
+import java.io.File;
+import java.nio.file.Files;
+
+// Normaly using * with imports is a bad practice, however in this case it makes experimenting with
+// Fluo easier.
+import org.apache.fluo.api.client.*;
+import org.apache.fluo.api.config.*;
+import org.apache.fluo.api.data.*;
+import org.apache.fluo.api.mini.MiniFluo;
+import org.apache.fluo.api.observer.*;
+
+public class Main {
+ public static void main(String[] args) throws Exception {
+
+ String tmpDir = Files.createTempDirectory(new File("target").toPath(), "mini").toString();
--- End diff --
My comment was that you can replace `new File("target").toPath()` with `Paths.get("target")`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79827697
--- Diff: src/main/java/ft/Main.java ---
@@ -0,0 +1,44 @@
+package ft;
+
+import java.io.File;
+import java.nio.file.Files;
+
+// Normaly using * with imports is a bad practice, however in this case it makes experimenting with
+// Fluo easier.
+import org.apache.fluo.api.client.*;
+import org.apache.fluo.api.config.*;
+import org.apache.fluo.api.data.*;
+import org.apache.fluo.api.mini.MiniFluo;
+import org.apache.fluo.api.observer.*;
+
+public class Main {
+ public static void main(String[] args) throws Exception {
+
+ String tmpDir = Files.createTempDirectory(new File("target").toPath(), "mini").toString();
+ // System.out.println("tmp dir : "+tmpDir);
--- End diff --
It might be nice print out this directory after MiniFluo is started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79885872
--- Diff: pom.xml ---
@@ -0,0 +1,93 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.fluo</groupId>
+ <artifactId>fluo-tour</artifactId>
+ <version>0.0.1-SNAPSHOT</version>
+ <packaging>jar</packaging>
+
+ <name>fluo-tour</name>
+ <url>https://fluo.apache.org/tour</url>
+
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <accumulo.version>1.7.2</accumulo.version>
+ <fluo.version>1.0.0-incubating</fluo.version>
+ </properties>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>3.1</version>
+ <configuration>
+ <source>1.8</source>
+ <target>1.8</target>
+ <optimize>true</optimize>
+ <encoding>UTF-8</encoding>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>1.5.0</version>
+ <configuration>
+ <mainClass>ft.Main</mainClass>
+ <cleanupDaemonThreads>false</cleanupDaemonThreads>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.accumulo</groupId>
+ <artifactId>accumulo-minicluster</artifactId>
+ <version>${accumulo.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.accumulo</groupId>
+ <artifactId>accumulo-core</artifactId>
+ <version>${accumulo.version}</version>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
+
+ <dependencies>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>4.11</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
--- End diff --
I need to look into if the tour is using these
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79826320
--- Diff: README.md ---
@@ -1,4 +1,17 @@
Fluo Tour
---------
+The git repository provides a barebones Maven+Java environment for the [Fluo Tour][tour]. As you go
+through the Tour edit [Main.java] and then use the following command to execute Main. This command
--- End diff --
could be `use the following command to get all of the correct dependencies on the classpath and execute Main`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79825905
--- Diff: README.md ---
@@ -1,4 +1,17 @@
Fluo Tour
---------
+The git repository provides a barebones Maven+Java environment for the [Fluo Tour][tour]. As you go
--- End diff --
Should be `This git repository`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79826044
--- Diff: README.md ---
@@ -1,4 +1,17 @@
Fluo Tour
---------
+The git repository provides a barebones Maven+Java environment for the [Fluo Tour][tour]. As you go
+through the Tour edit [Main.java] and then use the following command to execute Main. This command
--- End diff --
`through the tour`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79828012
--- Diff: src/main/java/ft/Main.java ---
@@ -0,0 +1,44 @@
+package ft;
+
+import java.io.File;
+import java.nio.file.Files;
+
+// Normaly using * with imports is a bad practice, however in this case it makes experimenting with
--- End diff --
Should be `Normally`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79831447
--- Diff: src/main/java/ft/Main.java ---
@@ -0,0 +1,44 @@
+package ft;
+
+import java.io.File;
+import java.nio.file.Files;
+
+// Normaly using * with imports is a bad practice, however in this case it makes experimenting with
+// Fluo easier.
+import org.apache.fluo.api.client.*;
+import org.apache.fluo.api.config.*;
+import org.apache.fluo.api.data.*;
+import org.apache.fluo.api.mini.MiniFluo;
+import org.apache.fluo.api.observer.*;
+
+public class Main {
+ public static void main(String[] args) throws Exception {
+
+ String tmpDir = Files.createTempDirectory(new File("target").toPath(), "mini").toString();
--- End diff --
Could use Paths instead of File:
```java
String tmpDir = Files.createTempDirectory(Paths.get("target"), "mini-").toString();
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79886627
--- Diff: pom.xml ---
@@ -0,0 +1,93 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.fluo</groupId>
+ <artifactId>fluo-tour</artifactId>
+ <version>0.0.1-SNAPSHOT</version>
+ <packaging>jar</packaging>
+
+ <name>fluo-tour</name>
+ <url>https://fluo.apache.org/tour</url>
+
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <accumulo.version>1.7.2</accumulo.version>
+ <fluo.version>1.0.0-incubating</fluo.version>
+ </properties>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>3.1</version>
+ <configuration>
+ <source>1.8</source>
+ <target>1.8</target>
+ <optimize>true</optimize>
+ <encoding>UTF-8</encoding>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>1.5.0</version>
+ <configuration>
+ <mainClass>ft.Main</mainClass>
+ <cleanupDaemonThreads>false</cleanupDaemonThreads>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.accumulo</groupId>
+ <artifactId>accumulo-minicluster</artifactId>
+ <version>${accumulo.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.accumulo</groupId>
+ <artifactId>accumulo-core</artifactId>
+ <version>${accumulo.version}</version>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
+
+ <dependencies>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>4.11</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
--- End diff --
They don't seem to be used by the tour at the moment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79888429
--- Diff: src/main/java/ft/Main.java ---
@@ -0,0 +1,44 @@
+package ft;
+
+import java.io.File;
+import java.nio.file.Files;
+
+// Normaly using * with imports is a bad practice, however in this case it makes experimenting with
+// Fluo easier.
+import org.apache.fluo.api.client.*;
+import org.apache.fluo.api.config.*;
+import org.apache.fluo.api.data.*;
+import org.apache.fluo.api.mini.MiniFluo;
+import org.apache.fluo.api.observer.*;
+
+public class Main {
+ public static void main(String[] args) throws Exception {
+
+ String tmpDir = Files.createTempDirectory(new File("target").toPath(), "mini").toString();
--- End diff --
Ok I see. I made that change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website issue #18: turned quickstart into fluo tour
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on the issue:
https://github.com/apache/incubator-fluo-website/pull/18
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-fluo-website/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79827386
--- Diff: pom.xml ---
@@ -0,0 +1,93 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.fluo</groupId>
+ <artifactId>fluo-tour</artifactId>
+ <version>0.0.1-SNAPSHOT</version>
+ <packaging>jar</packaging>
+
+ <name>fluo-tour</name>
+ <url>https://fluo.apache.org/tour</url>
+
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <accumulo.version>1.7.2</accumulo.version>
+ <fluo.version>1.0.0-incubating</fluo.version>
+ </properties>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>3.1</version>
+ <configuration>
+ <source>1.8</source>
+ <target>1.8</target>
+ <optimize>true</optimize>
+ <encoding>UTF-8</encoding>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>1.5.0</version>
+ <configuration>
+ <mainClass>ft.Main</mainClass>
+ <cleanupDaemonThreads>false</cleanupDaemonThreads>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.accumulo</groupId>
+ <artifactId>accumulo-minicluster</artifactId>
+ <version>${accumulo.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.accumulo</groupId>
+ <artifactId>accumulo-core</artifactId>
+ <version>${accumulo.version}</version>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
+
+ <dependencies>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>4.11</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
--- End diff --
There are couple of dependencies that are declared but not used:
```
[WARNING] Unused declared dependencies found:
[WARNING] junit:junit:jar:4.11:test
[WARNING] com.beust:jcommander:jar:1.32:compile
[WARNING] com.google.guava:guava:jar:14.0.1:compile
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---