You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openoffice.apache.org by ms...@apache.org on 2020/07/28 11:22:30 UTC

[openoffice] branch AOO42X updated (4eccd1a -> c169aa3)

This is an automated email from the ASF dual-hosted git repository.

mseidel pushed a change to branch AOO42X
in repository https://gitbox.apache.org/repos/asf/openoffice.git.


    from 4eccd1a  Fixed close button for Help Agent
     new ca8e4e5  Explain format of "-tm" parameter when it's wrong.
     new 99b5c64  Fix a test timing issue, and deal with "Save changes" dialog.
     new c169aa3  Fix another test timing issue.

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 test/testcommon/source/org/openoffice/test/common/NamedRequest.java  | 5 ++++-
 .../source/fvt/gui/formula/importexport/FormulaInDifferentWays.java  | 4 +++-
 2 files changed, 7 insertions(+), 2 deletions(-)


[openoffice] 03/03: Fix another test timing issue.

Posted by ms...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

mseidel pushed a commit to branch AOO42X
in repository https://gitbox.apache.org/repos/asf/openoffice.git

commit c169aa37468d7e3ce395fa0ac5eed9c16bc24f88
Author: Damjan Jovanovic <da...@apache.org>
AuthorDate: Mon Jul 27 07:59:59 2020 +0200

    Fix another test timing issue.
    
    Patch by: me
    
    (cherry picked from commit 557ccdce2ed90616cf241d2123da4f80f65e7c70)
---
 .../source/fvt/gui/formula/importexport/FormulaInDifferentWays.java      | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/testgui/source/fvt/gui/formula/importexport/FormulaInDifferentWays.java b/test/testgui/source/fvt/gui/formula/importexport/FormulaInDifferentWays.java
index c241181..3c00f12 100644
--- a/test/testgui/source/fvt/gui/formula/importexport/FormulaInDifferentWays.java
+++ b/test/testgui/source/fvt/gui/formula/importexport/FormulaInDifferentWays.java
@@ -89,6 +89,7 @@ public class FormulaInDifferentWays {
 		// commands window
 		mathElementsRelations.click();
 		mathElementsRelationsNotEqual.click();
+		sleep(1);
 		typeKeys("a");
 		app.dispatch(".uno:NextMark");
 		typeKeys("b");


[openoffice] 01/03: Explain format of "-tm" parameter when it's wrong.

Posted by ms...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

mseidel pushed a commit to branch AOO42X
in repository https://gitbox.apache.org/repos/asf/openoffice.git

commit ca8e4e5a6119f0ceaa44e8c3538f3568ab0aeabd
Author: Damjan Jovanovic <da...@apache.org>
AuthorDate: Mon Jul 27 07:31:25 2020 +0200

    Explain format of "-tm" parameter when it's wrong.
    
    Patch by: me
    
    (cherry picked from commit 3705dcbca917f01156f9b8d7e49186e5358fb78b)
---
 test/testcommon/source/org/openoffice/test/common/NamedRequest.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/test/testcommon/source/org/openoffice/test/common/NamedRequest.java b/test/testcommon/source/org/openoffice/test/common/NamedRequest.java
index ffb4b6e..dbfbe55 100644
--- a/test/testcommon/source/org/openoffice/test/common/NamedRequest.java
+++ b/test/testcommon/source/org/openoffice/test/common/NamedRequest.java
@@ -123,6 +123,9 @@ public class NamedRequest extends Request {
 		String[] methods = arg.split(",");
 		for (String m : methods) {
 			int i = m.lastIndexOf(".");
+			if (i < 0) {
+				throw new RuntimeException("-tm parameter needs to have the form className.methodName");
+			}
 			String className = m.substring(0, i);
 			String methodName = m.substring(++i);
 			try {
@@ -179,4 +182,4 @@ public class NamedRequest extends Request {
 		}
 	}
 
-}
\ No newline at end of file
+}


[openoffice] 02/03: Fix a test timing issue, and deal with "Save changes" dialog.

Posted by ms...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

mseidel pushed a commit to branch AOO42X
in repository https://gitbox.apache.org/repos/asf/openoffice.git

commit 99b5c6424da9b55b8de5b1d91fb7378ff629b9b5
Author: Damjan Jovanovic <da...@apache.org>
AuthorDate: Mon Jul 27 07:32:01 2020 +0200

    Fix a test timing issue, and deal with "Save changes" dialog.
    
    Patch by: me
    
    (cherry picked from commit fbeee538df5958e9c8ad230af896b4c8175ab763)
---
 .../source/fvt/gui/formula/importexport/FormulaInDifferentWays.java    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/testgui/source/fvt/gui/formula/importexport/FormulaInDifferentWays.java b/test/testgui/source/fvt/gui/formula/importexport/FormulaInDifferentWays.java
index aec77ea..c241181 100644
--- a/test/testgui/source/fvt/gui/formula/importexport/FormulaInDifferentWays.java
+++ b/test/testgui/source/fvt/gui/formula/importexport/FormulaInDifferentWays.java
@@ -54,7 +54,7 @@ public class FormulaInDifferentWays {
 
 	@After
 	public void tearDown() throws Exception {
-		close();
+		discard();
 		app.stop();
 	}
 
@@ -167,6 +167,7 @@ public class FormulaInDifferentWays {
 		// commands window
 		mathElementsUnaryBinary.click();
 		mathElementsUnaryBinaryPlus.click();
+		sleep(1);
 		typeKeys("a"); // "+a";
 
 		// Undo and verify if it works fine