[GitHub] [arrow] bkietz commented on pull request #10722: ARROW-13344: [R] Initial bindings for ExecPlan/ExecNode

[GitBox <gi...@apache.org>]

bkietz commented on pull request #10722:
URL: https://github.com/apache/arrow/pull/10722#issuecomment-890076863


   > -    MakeScalarAggregateNode and MakeGroupByNode have quite different function signatures, which makes working with the API confusing
   > -    GroupBy doesn't let you specify the names of the output columns
   
   ARROW-13482 (#10793) unifies the factories for scalar and grouped aggregation. I'll ensure that PR also provides configurable output column names for both
   
   -    Grouped aggregation functions all have to be invoked with a hash_ prefix to the name, which seems unnecessary because you can't call a non-hash-aggregation function in GroupBy and you can't call a hash_ function in ScalarAggregate
   
   ARROW-13451 would allow grouping of grouped and scalar aggregation kernels under the same function (rather than requiring distinct `sum` and `hash_sum` functions), which I think would address these
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org