You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2001/09/08 11:25:02 UTC

Re: svn commit: revision 70 - trunk

Ladies and Gentlemen,

We are proud and honoured to have the privilege to present to you

        The Commit from Windows



brane@tigris.org wrote:

>Author: brane
>Date: 2001-09-08 11:10 GMT
>New Revision: 70
>
>Modified:
>   trunk/svn_private_config.hw
>Log:
>(SVN_VERSION): Bump to M3.
>
>Modified: trunk/svn_private_config.hw
>==============================================================================
>--- OLD/trunk/svn_private_config.hw	Sat Sep  8 06:10:41 2001
>+++ NEW/trunk/svn_private_config.hw	Sat Sep  8 06:10:41 2001
>@@ -60,7 +60,7 @@
> #endif
> 
> /* Subversion Version string */
>-#define SVN_VERSION "M2 (pre-alpha)"
>+#define SVN_VERSION "M3"
> 
> /* Link local repos access library to client */
> #define SVN_LIBSVN_CLIENT_LINKS_RA_LOCAL
>

-- 
Brane �ibej   <br...@xbc.nu>            http://www.xbc.nu/brane/




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: revision 70 - trunk

Posted by Branko Čibej <br...@xbc.nu>.
Branko �ibej wrote:

> Oh, yes: I've also got mods to APR (apr_filepath_merge, 
> apr_filepath_get), but I have to research the impact on apr-util and 
> httpd-2.0 before I dare commit those changes.
>
>

Well, it seems that neither apr-util nor httpd-2.0 will mind (I changed 
the declaration of apr_filepath_get). But I don't have time to test 
those changes on Unix. So I'm attaching a patch for APR. Anyone who 
wants to test on Windows will need this patch to make commits work.


-- 
Brane �ibej   <br...@xbc.nu>            http://www.xbc.nu/brane/



Re: svn commit: revision 70 - trunk

Posted by Branko Čibej <br...@xbc.nu>.
Oh, yes: I've also got mods to APR (apr_filepath_merge, 
apr_filepath_get), but I have to research the impact on apr-util and 
httpd-2.0 before I dare commit those changes.


-- 
Brane �ibej   <br...@xbc.nu>            http://www.xbc.nu/brane/




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: revision 70 - trunk

Posted by Branko Čibej <br...@xbc.nu>.
By the way, I have a local mod here to make this work:


--- subversion/libsvn_subr/SVN/text-base/path.c Fri Aug 31 23:29:40 2001
+++ subversion/libsvn_subr/path.c       Sat Sep  8 12:58:20 2001
@@ -95,7 +95,13 @@ add_component_internal (svn_stringbuf_t
                         size_t len,
                         enum svn_path_style style)
 {
-  char dirsep = get_separator_from_style (style);
+  char dirsep;
+
+  /* FIXME: Don't ever add a single dot to the path. */
+  if (len == 1 && *component == '.')
+    return;
+
+  dirsep = get_separator_from_style (style);

   if (! svn_stringbuf_isempty (path))
     svn_stringbuf_appendbytes (path, &dirsep, sizeof (dirsep));





That's because the Win32 functions used by APR die if they get a path 
ending in '\.'. Don't ask me why.

I'm not going to commit this because it would probably break things on 
Unix, if the original path happens to be a symlink to a directory. I 
think this is an APR problem and should be fixed there.


-- 
Brane �ibej   <br...@xbc.nu>            http://www.xbc.nu/brane/




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org