You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Jie Yu (JIRA)" <ji...@apache.org> on 2015/08/08 02:16:46 UTC

[jira] [Commented] (MESOS-2463) Slaves sends mutated copy of executorinfo to new elected master

    [ https://issues.apache.org/jira/browse/MESOS-2463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662688#comment-14662688 ] 

Jie Yu commented on MESOS-2463:
-------------------------------

commit 210dadf002dcee838e4a6fd245aea6f4601103d8
Author: Jie Yu <yu...@gmail.com>
Date:   Tue Aug 4 12:00:02 2015 -0700

    Stopped mutating executor info with default container info.
    
    Review: https://reviews.apache.org/r/37091

> Slaves sends mutated copy of executorinfo to new elected master
> ---------------------------------------------------------------
>
>                 Key: MESOS-2463
>                 URL: https://issues.apache.org/jira/browse/MESOS-2463
>             Project: Mesos
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Chi Zhang
>            Assignee: Kapil Arya
>            Priority: Blocker
>              Labels: mesosphere
>             Fix For: 0.22.0
>
>
> {code}
> static ExecutorInfo decorateExecutorEnvironment(
>     ExecutorInfo executorInfo,
>     const TaskInfo& taskInfo)
> {
>   // Merge environment variables retrieved from label-decorator hooks.
>   executorInfo.mutable_command()->mutable_environment()->MergeFrom(
>       HookManager::slaveLaunchExecutorEnvironmentDecorator(
>           executorInfo,
>           taskInfo));
>   return executorInfo;
> }
> {code}
> does a default allocation of environment, even when the original ExecutorInfo doesn't have one set.
> When a new master is elected and receives this copy, it would reject tasks for the same Executor because of this difference:
> Existing ExecutorInfo has :
> command {
> uris
> { value: "/usr/local/bin/gc_executor" executable: true }
> environment {
> }
> value: "./gc_executor"
> }
> framework_id
> { value: "201103282247-0000000019-0000" }
> ------------------------------------------------------------
> New Task's ExecutorInfo has:
> command {
> uris
> { value: "/usr/local/bin/gc_executor" executable: true }
> value: "./gc_executor"
> }
> framework_id
> { value: "201103282247-0000000019-0000" } 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)