You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Vlad Dogaru (JIRA)" <ji...@apache.org> on 2011/08/16 03:46:27 UTC
[jira] [Created] (HBASE-4201) Fix delayed RPC crash
Fix delayed RPC crash
---------------------
Key: HBASE-4201
URL: https://issues.apache.org/jira/browse/HBASE-4201
Project: HBase
Issue Type: Bug
Components: ipc
Reporter: Vlad Dogaru
Priority: Minor
Delayed RPC crashes if return value is not delayed and endDelay is called before the actual function returns a value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4201) Fix delayed RPC crash
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4201:
-------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
Marking patch available.
> Fix delayed RPC crash
> ---------------------
>
> Key: HBASE-4201
> URL: https://issues.apache.org/jira/browse/HBASE-4201
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Vlad Dogaru
> Priority: Minor
>
> Delayed RPC crashes if return value is not delayed and endDelay is called before the actual function returns a value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4201) Fix delayed RPC crash
Posted by "Ian Varley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446447#comment-13446447 ]
Ian Varley commented on HBASE-4201:
-----------------------------------
Hey Stack: any reason this never got committed? Just needs followup / update to trunk? Patch looks good and relatively small.
> Fix delayed RPC crash
> ---------------------
>
> Key: HBASE-4201
> URL: https://issues.apache.org/jira/browse/HBASE-4201
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Vlad Dogaru
> Assignee: Vlad Dogaru
> Priority: Minor
>
> Delayed RPC crashes if return value is not delayed and endDelay is called before the actual function returns a value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4201) Fix delayed RPC crash
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4201:
-------------------------
Attachment: HBASE-4201-v1.patch
Copying patch over from rb (Let us know if that is not ok Vlad)
> Fix delayed RPC crash
> ---------------------
>
> Key: HBASE-4201
> URL: https://issues.apache.org/jira/browse/HBASE-4201
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Vlad Dogaru
> Assignee: Vlad Dogaru
> Priority: Minor
> Attachments: HBASE-4201-v1.patch
>
>
> Delayed RPC crashes if return value is not delayed and endDelay is called before the actual function returns a value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4201) Fix delayed RPC crash
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085994#comment-13085994 ]
jiraposter@reviews.apache.org commented on HBASE-4201:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1519/#review1486
-----------------------------------------------------------
Ship it!
LGTM
- Michael
On 2011-08-16 01:49:32, Vlad Dogaru wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1519/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-16 01:49:32)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This was initially part of the larger patch for HBASE-4192, but it is semantically independent and I split it to a new patch and added a unit test at Todd's suggestion.
bq.
bq.
bq. This addresses bug HBASE-4201.
bq. https://issues.apache.org/jira/browse/HBASE-4201
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 7117bce
bq. src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java 0b21c6c
bq.
bq. Diff: https://reviews.apache.org/r/1519/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran TestDelayedRpc, added a new test case for this situation.
bq.
bq.
bq. Thanks,
bq.
bq. Vlad
bq.
bq.
> Fix delayed RPC crash
> ---------------------
>
> Key: HBASE-4201
> URL: https://issues.apache.org/jira/browse/HBASE-4201
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Vlad Dogaru
> Priority: Minor
>
> Delayed RPC crashes if return value is not delayed and endDelay is called before the actual function returns a value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4201) Fix delayed RPC crash
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4201:
-------------------------
Attachment: 4201.txt
Here is an attempt at forwarding porting the patch only the test code has all changed (pb'ing).
Needs a bit more work to get it in Ian.
> Fix delayed RPC crash
> ---------------------
>
> Key: HBASE-4201
> URL: https://issues.apache.org/jira/browse/HBASE-4201
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Vlad Dogaru
> Assignee: Vlad Dogaru
> Priority: Minor
> Attachments: 4201.txt, HBASE-4201-v1.patch
>
>
> Delayed RPC crashes if return value is not delayed and endDelay is called before the actual function returns a value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4201) Fix delayed RPC crash
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085483#comment-13085483 ]
jiraposter@reviews.apache.org commented on HBASE-4201:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1519/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
This was initially part of the larger patch for HBASE-4192, but it is semantically independent and I split it to a new patch and added a unit test at Todd's suggestion.
This addresses bug HBASE-4201.
https://issues.apache.org/jira/browse/HBASE-4201
Diffs
-----
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 7117bce
src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java 0b21c6c
Diff: https://reviews.apache.org/r/1519/diff
Testing
-------
Ran TestDelayedRpc, added a new test case for this situation.
Thanks,
Vlad
> Fix delayed RPC crash
> ---------------------
>
> Key: HBASE-4201
> URL: https://issues.apache.org/jira/browse/HBASE-4201
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Vlad Dogaru
> Priority: Minor
>
> Delayed RPC crashes if return value is not delayed and endDelay is called before the actual function returns a value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4201) Fix delayed RPC crash
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-4201:
----------------------------
Assignee: Vlad Dogaru
Assigning Vlad.
> Fix delayed RPC crash
> ---------------------
>
> Key: HBASE-4201
> URL: https://issues.apache.org/jira/browse/HBASE-4201
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Reporter: Vlad Dogaru
> Assignee: Vlad Dogaru
> Priority: Minor
>
> Delayed RPC crashes if return value is not delayed and endDelay is called before the actual function returns a value.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira