You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "laddcn (GitHub)" <gi...@apache.org> on 2020/03/08 14:36:20 UTC

[GitHub] [dubbo] laddcn opened pull request #5841: Fix wrong comment with DubboBootstrap.useRegistryAsConfigCenterIfNecessary

## What is the purpose of the change

Fix wrong comment with DubboBootstrap.useRegistryAsConfigCenterIfNecessary

## Brief changelog

Original comment mentioned "For compatibility purpose, use registry as the default config center when the registry protocol is zookeeper and there's no config center specified explicitly.".
However, it seems this method works ignore the registry protocol because it use registry as the default config when I use nacos as registry protocol.
I debugged this method and found out this method will use registry as the default config when there's no config center specified explicitly and useAsConfigCenter of registryConfig is null or true. So I modified this comment.

## Verifying this change

All test cases work fine.

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/dubbo/pull/5841 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org