[GitHub] [superset] AAfghahi commented on a diff in pull request #21948: feat: Integrate ant d table component into DatasetPanel

[GitBox <gi...@apache.org>]

AAfghahi commented on code in PR #21948:
URL: https://github.com/apache/superset/pull/21948#discussion_r1019441865


##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx:
##########
@@ -0,0 +1,237 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { supersetTheme, t, styled } from '@superset-ui/core';
+import Icons from 'src/components/Icons';
+import Table, { ColumnsType, TableSize } from 'src/components/Table';
+import { alphabeticalSort } from 'src/components/Table/sorters';
+// @ts-ignore
+import LOADING_GIF from 'src/assets/images/loading.gif';
+import { ITableColumn } from './types';
+import MessageContent from './MessageContent';
+
+/**
+ * Enum defining CSS position options
+ */
+enum EPosition {
+  ABSOLUTE = 'absolute',
+  RELATIVE = 'relative',
+}
+
+/**
+ * Interface for StyledHeader
+ */
+interface StyledHeaderProps {
+  /**
+   * Determine the CSS positioning type
+   * Vertical centering of loader, No columns screen, and select table screen
+   * gets offset when the header position is relative and needs to be absolute, but table
+   * needs this positioned relative to render correctly
+   */
+  position: EPosition;
+}
+
+const LOADER_WIDTH = 200;
+const SPINNER_WIDTH = 120;
+const HALF = 0.5;
+const MARGIN_MULTIPLIER = 3;

Review Comment:
   quick question: How were these determined?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org