You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/11/21 03:15:39 UTC
[commons-vfs] branch master updated: Use final.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git
The following commit(s) were added to refs/heads/master by this push:
new 1b4a31f Use final.
1b4a31f is described below
commit 1b4a31fbea7629e24707611ab3194f1443f48168
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Nov 20 22:15:34 2020 -0500
Use final.
---
.../src/main/java/org/apache/commons/vfs2/UserAuthenticationData.java | 2 +-
.../src/main/java/org/apache/commons/vfs2/impl/VFSClassLoader.java | 2 +-
.../apache/commons/vfs2/operations/AbstractFileOperationProvider.java | 2 +-
.../java/org/apache/commons/vfs2/provider/AbstractFileObject.java | 2 +-
.../main/java/org/apache/commons/vfs2/provider/ram/RamFileSystem.java | 2 +-
.../java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java | 2 +-
.../apache/commons/vfs2/util/DelegatingFileSystemOptionsBuilder.java | 2 +-
.../commons/vfs2/provider/sftp/test/AbstractSftpProviderTestCase.java | 2 +-
.../apache/commons/vfs2/provider/zip/test/ZipFileSystemTestCase.java | 4 ++--
9 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/UserAuthenticationData.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/UserAuthenticationData.java
index f5a74d3..1be00ba 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/UserAuthenticationData.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/UserAuthenticationData.java
@@ -121,7 +121,7 @@ public class UserAuthenticationData {
*/
public void cleanup() {
// step 1: nullify character buffers
- for (char[] data : authenticationData.values()) {
+ for (final char[] data : authenticationData.values()) {
if (data == null) {
continue;
}
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/VFSClassLoader.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/VFSClassLoader.java
index 8a52393..6396b6a 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/VFSClassLoader.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/impl/VFSClassLoader.java
@@ -268,7 +268,7 @@ public class VFSClassLoader extends SecureClassLoader {
* Does a reverse lookup to find the FileObject when we only have the URL.
*/
private FileObject lookupFileObject(final String name) {
- for (FileObject object : resources) {
+ for (final FileObject object : resources) {
if (name.equals(object.getName().getURI())) {
return object;
}
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/operations/AbstractFileOperationProvider.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/operations/AbstractFileOperationProvider.java
index 0da14da..624ebcc 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/operations/AbstractFileOperationProvider.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/operations/AbstractFileOperationProvider.java
@@ -106,7 +106,7 @@ public abstract class AbstractFileOperationProvider implements FileOperationProv
// find appropriate class
Class<? extends FileOperation> foundClass = null;
- for (Class<? extends FileOperation> operation : operations) {
+ for (final Class<? extends FileOperation> operation : operations) {
if (operationClass.isAssignableFrom(operation)) {
foundClass = operation;
break;
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
index a76d2f2..316e67e 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
@@ -409,7 +409,7 @@ public abstract class AbstractFileObject<AFS extends AbstractFileSystem> impleme
// Delete 'em
final int count = files.size();
- for (FileObject fileObject : files) {
+ for (final FileObject fileObject : files) {
final AbstractFileObject file = FileObjectUtils.getAbstractFileObject(fileObject);
// file.attach();
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileSystem.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileSystem.java
index 67888f7..832529f 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileSystem.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileSystem.java
@@ -249,7 +249,7 @@ public class RamFileSystem extends AbstractFileSystem implements Serializable {
long size() {
long size = 0;
synchronized (cache) {
- for (RamFileData data : cache.values()) {
+ for (final RamFileData data : cache.values()) {
size += data.size();
}
}
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java
index 2eaa7a0..70a1de7 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java
@@ -76,7 +76,7 @@ public final class SftpClientFactory {
final ConfigRepository configRepository = builder.getConfigRepository(fileSystemOptions);
final boolean loadOpenSSHConfig = builder.isLoadOpenSSHConfig(fileSystemOptions);
- File sshDir = findSshDir();
+ final File sshDir = findSshDir();
setKnownHosts(jsch, sshDir, knownHostsFile);
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DelegatingFileSystemOptionsBuilder.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DelegatingFileSystemOptionsBuilder.java
index 594a2af..ac7bb6f 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DelegatingFileSystemOptionsBuilder.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/DelegatingFileSystemOptionsBuilder.java
@@ -194,7 +194,7 @@ public class DelegatingFileSystemOptionsBuilder {
ctx.fileSystemConfigBuilder = getManager().getFileSystemConfigBuilder(ctx.scheme);
// try to find a setter which could accept the value
- for (Method configSetter : ctx.configSetters) {
+ for (final Method configSetter : ctx.configSetters) {
if (convertValuesAndInvoke(configSetter, ctx)) {
return;
}
diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/sftp/test/AbstractSftpProviderTestCase.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/sftp/test/AbstractSftpProviderTestCase.java
index 2e1fbeb..8eac8a1 100644
--- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/sftp/test/AbstractSftpProviderTestCase.java
+++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/sftp/test/AbstractSftpProviderTestCase.java
@@ -461,7 +461,7 @@ abstract class AbstractSftpProviderTestCase extends AbstractProviderTestConfig {
private String[] extended;
private SftpAttrs(final Buffer buf) {
- int flags = buf.getInt();
+ final int flags = buf.getInt();
if ((flags & SftpATTRS.SSH_FILEXFER_ATTR_SIZE) != 0) {
size = buf.getLong();
diff --git a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/test/ZipFileSystemTestCase.java b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/test/ZipFileSystemTestCase.java
index 792f6e3..883c14d 100644
--- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/test/ZipFileSystemTestCase.java
+++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/zip/test/ZipFileSystemTestCase.java
@@ -33,8 +33,8 @@ public class ZipFileSystemTestCase {
@Test
public void testZipFileUseWeakRefFilesCache() throws FileSystemException {
- File file = new File("src/test/resources/test-data/test.zip");
- String fileUri = "zip:file:" + file.getAbsolutePath();
+ final File file = new File("src/test/resources/test-data/test.zip");
+ final String fileUri = "zip:file:" + file.getAbsolutePath();
FileObject fileObject = null;
try (StandardFileSystemManager manager = new StandardFileSystemManager()) {