You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by srinathman <gi...@git.apache.org> on 2014/07/30 16:53:17 UTC

[GitHub] bigtop pull request: Allow multiple flume instances

GitHub user srinathman opened a pull request:

    https://github.com/apache/bigtop/pull/6

    Allow multiple flume instances

    It was not possible to use the script to start multiple instance. These changes allows multiple instances to be started be setting FLUME_AGENT_NAME or by writing a simple wrapper like:
    
    ---
    #!/bin/bash
    
    export FLUME_AGENT_NAME=$1 
    COMMAND=$2
    
    /etc/init.d/flume-ng-agent $COMMAND
    ---
    
    Ex:
    
    # flume-wrapper.sh start agent1
    # flume-wrapper.sh start agent2
    
    # flume-wrapper.sh stop agent1
    # flume-wrapper.sh stop agent2

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srinathman/bigtop master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bigtop/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6
    
----
commit 848514bde4ca719837dfc7648f174e29a8adf320
Author: srinathman <sr...@yahoo.com>
Date:   2014-07-30T14:50:33Z

    Allow multiple flume instances
    
    It was not possible to use the script to start multiple instance. These changes allows multiple instances to be started be setting FLUME_AGENT_NAME or by writing a simple wrapper like:
    
    ---
    #!/bin/bash
    
    export FLUME_AGENT_NAME=$1 
    COMMAND=$2
    
    /etc/init.d/flume-ng-agent $COMMAND
    ---
    
    Ex:
    
    # flume-wrapper.sh start agent1
    # flume-wrapper.sh start agent2
    
    # flume-wrapper.sh stop agent1
    # flume-wrapper.sh stop agent2

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop pull request: Allow multiple flume instances

Posted by srinathman <gi...@git.apache.org>.
Github user srinathman commented on the pull request:

    https://github.com/apache/bigtop/pull/6#issuecomment-50701097
  
    I wanted to keep the logic of having multiple instances out of the main the script but making it compatible nonetheless.
    If I didn't miss anything, all other stuff can be set via environement variable prior to calling the main script (config dir, agent name, etc).
    
    There is no associated Jira, If this is alright I'll try to send the patch via jira later..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop pull request: Allow multiple flume instances

Posted by mackrorysd <gi...@git.apache.org>.
Github user mackrorysd commented on the pull request:

    https://github.com/apache/bigtop/pull/6#issuecomment-50655889
  
    We do something similar for HBase RegionServers, where a user can list ID's for each RegionServer instance in a config file, and the init script will repeat each command for each ID, to start, stop, restart, and status-check the processes. Are there some commits or files missing from this pull-request, though? This seems to only change the name of the .out file and the .pid file - rather than doing anything multiple times.
    
    Keep in mind that when init scripts are invoked with the 'service' command you can only pass 1 argument, so if there are multiple FLUME_AGENT_NAMEs, they need to come from a file rather than the command line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop pull request: Allow multiple flume instances

Posted by jayunit100 <gi...@git.apache.org>.
Github user jayunit100 commented on the pull request:

    https://github.com/apache/bigtop/pull/6#issuecomment-50646292
  
    Thanks for this PR.  Is there an associated JIRA, and if so, could you attach a patch? 
    
    Creating a patch is extremely easy, just: check out the page here https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---