You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "MaryaAlamzeb (via GitHub)" <gi...@apache.org> on 2025/04/05 11:49:48 UTC
[PR] docs: Minor improvement to documentation for GSoC onboarding (Marya Alamzeb) [dolphinscheduler]
MaryaAlamzeb opened a new pull request, #17114:
URL: https://github.com/apache/dolphinscheduler/pull/17114
This PR improves the documentation for easier understanding and onboarding.
This change is submitted as part of my GSoC 2025 application process with the Apache DolphinScheduler project (GSOC-284).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] contribution doc improvement [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #17114:
URL: https://github.com/apache/dolphinscheduler/pull/17114#discussion_r2035558515
##########
docs/docs/en/contribute/join/issue.md:
##########
@@ -2,13 +2,10 @@
## Preface
-Issues function is used to track various Features, Bugs, Functions, etc. The project maintainer can organize the tasks to be completed through issues.
-
-Issue is an important step in drawing out a feature or bug,
-and the contents that can be discussed in an issue are not limited to the features, the causes of the existing bugs, the research on preliminary scheme, and the corresponding implementation design and code design.
-
-And only when the Issue is approved, the corresponding Pull Request should be implemented.
-
+Issues function is used to track various Features, Bugs, Functions, etc.
+The project maintainer can organize the tasks to be completed through issues.
+Issue is an important step in drawing out a feature or bug, and the contents that can be discussed in an issue are not limited to the features, the causes of the existing bugs, the research on preliminary scheme, and the corresponding implementation design and code design.
+When the Issue is approved, the corresponding Pull Request should be implemented accordingly.
Review Comment:
Why do this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Minor improvement to documentation for GSoC onboarding (Marya Alamzeb) [dolphinscheduler]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #17114:
URL: https://github.com/apache/dolphinscheduler/pull/17114#issuecomment-2780680480
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Minor improvement to documentation for GSoC onboarding (Marya Alamzeb) [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #17114:
URL: https://github.com/apache/dolphinscheduler/pull/17114#discussion_r2030444579
##########
docs/docs/en/contribute/join/contribute.md:
##########
@@ -38,3 +38,5 @@ If you want to implement a Feature or fix a Bug. Please refer to the following:
* When you're done, send a Pull Request to dolphinscheduler, please refer to the《[Submit Guide-Submit Pull Request Process](./submit-code.md)》
If you want to submit a Pull Request to complete a Feature or fix a Bug, it is recommended that you start with the `good first issue`, `easy-to-fix` issues, complete a small function to submit, do not change too many files at a time, changing too many files will also put a lot of pressure on Reviewers, it is recommended to submit them through multiple Pull Requests, not all at once.
+
+_Contributed as part of GSoC 2025 application by Marya Alamzeb_
Review Comment:
```suggestion
```
##########
docs/docs/en/contribute/join/contribute.md:
##########
@@ -38,3 +38,5 @@ If you want to implement a Feature or fix a Bug. Please refer to the following:
* When you're done, send a Pull Request to dolphinscheduler, please refer to the《[Submit Guide-Submit Pull Request Process](./submit-code.md)》
If you want to submit a Pull Request to complete a Feature or fix a Bug, it is recommended that you start with the `good first issue`, `easy-to-fix` issues, complete a small function to submit, do not change too many files at a time, changing too many files will also put a lot of pressure on Reviewers, it is recommended to submit them through multiple Pull Requests, not all at once.
+
+_Contributed as part of GSoC 2025 application by Marya Alamzeb_
Review Comment:
Please remove unnessnary change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] contribution doc improvement [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed pull request #17114: [Improvement] contribution doc improvement
URL: https://github.com/apache/dolphinscheduler/pull/17114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org