[GitHub] rabbah commented on a change in pull request #2964: Reject requests to create packages having the name 'default'

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #2964: Reject requests to create packages having the name 'default'
URL: https://github.com/apache/incubator-openwhisk/pull/2964#discussion_r150681079
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/Packages.scala
 ##########
 @@ -76,25 +76,30 @@ trait WhiskPackagesApi extends WhiskCollectionAPI with ReferencedEntities {
    */
   override def create(user: Identity, entityName: FullyQualifiedEntityName)(implicit transid: TransactionId) = {
     parameter('overwrite ? false) { overwrite =>
-      entity(as[WhiskPackagePut]) { content =>
-        val request = content.resolve(entityName.namespace)
+      if (!overwrite && entityName.name.toString == "default") {
+        logging.info(this, "attempt to create a package named 'default'")
 
 Review comment:
   We can probably do away with this log message or use debug level 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services