You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/13 01:22:27 UTC
[GitHub] [airflow] kazanzhy opened a new pull request #20246: Fix MyPy Errors for HTTP provider.
kazanzhy opened a new pull request #20246:
URL: https://github.com/apache/airflow/pull/20246
Fix MyPy Errors for HTTP provider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20246: Fix MyPy Errors for HTTP provider.
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20246:
URL: https://github.com/apache/airflow/pull/20246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kazanzhy commented on a change in pull request #20246: Fix MyPy Errors for HTTP provider.
Posted by GitBox <gi...@apache.org>.
kazanzhy commented on a change in pull request #20246:
URL: https://github.com/apache/airflow/pull/20246#discussion_r767573022
##########
File path: airflow/providers/http/hooks/http.py
##########
@@ -186,8 +186,8 @@ def run_and_check(
# Send the request.
send_kwargs = {
- "timeout": extra_options.get("timeout"),
"allow_redirects": extra_options.get("allow_redirects", True),
+ "timeout": extra_options.get("timeout"),
Review comment:
Thanks, @uranusjr. It also works. Made changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #20246: Fix MyPy Errors for HTTP provider.
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #20246:
URL: https://github.com/apache/airflow/pull/20246#discussion_r767544714
##########
File path: airflow/providers/http/hooks/http.py
##########
@@ -186,8 +186,8 @@ def run_and_check(
# Send the request.
send_kwargs = {
- "timeout": extra_options.get("timeout"),
"allow_redirects": extra_options.get("allow_redirects", True),
+ "timeout": extra_options.get("timeout"),
Review comment:
Does not seem it fixes anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kazanzhy commented on a change in pull request #20246: Fix MyPy Errors for HTTP provider.
Posted by GitBox <gi...@apache.org>.
kazanzhy commented on a change in pull request #20246:
URL: https://github.com/apache/airflow/pull/20246#discussion_r767555129
##########
File path: airflow/providers/http/hooks/http.py
##########
@@ -186,8 +186,8 @@ def run_and_check(
# Send the request.
send_kwargs = {
- "timeout": extra_options.get("timeout"),
"allow_redirects": extra_options.get("allow_redirects", True),
+ "timeout": extra_options.get("timeout"),
Review comment:
I get the error
```
Argument 2 to "send" of "Session" has incompatible type "**Dict[str, Optional[Any]]"; expected "bool"
```
And these parameters switch helped avoid the error. Very strange
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20246: Fix MyPy Errors for HTTP provider.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20246:
URL: https://github.com/apache/airflow/pull/20246#issuecomment-992300830
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #20246: Fix MyPy Errors for HTTP provider.
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #20246:
URL: https://github.com/apache/airflow/pull/20246#discussion_r767544557
##########
File path: airflow/providers/http/hooks/http.py
##########
@@ -186,8 +186,8 @@ def run_and_check(
# Send the request.
send_kwargs = {
- "timeout": extra_options.get("timeout"),
"allow_redirects": extra_options.get("allow_redirects", True),
+ "timeout": extra_options.get("timeout"),
Review comment:
Hmm. What was the problem here :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #20246: Fix MyPy Errors for HTTP provider.
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #20246:
URL: https://github.com/apache/airflow/pull/20246#discussion_r767561156
##########
File path: airflow/providers/http/hooks/http.py
##########
@@ -186,8 +186,8 @@ def run_and_check(
# Send the request.
send_kwargs = {
- "timeout": extra_options.get("timeout"),
"allow_redirects": extra_options.get("allow_redirects", True),
+ "timeout": extra_options.get("timeout"),
Review comment:
Annotate `send_kwargs` as `Dict[str, Any]` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org