You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by holdenk <gi...@git.apache.org> on 2016/03/29 18:10:44 UTC

[GitHub] spark pull request: [SPARK-12334][SQL][PYSPARK] Support read from ...

Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10307#discussion_r57751258
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
    @@ -164,6 +165,14 @@ class OrcQuerySuite extends QueryTest with BeforeAndAfterAll with OrcTest {
         }
       }
     
    +  test("read from multiple input paths") {
    +    val path1 = Utils.createTempDir()
    +    val path2 = Utils.createTempDir()
    +    makeOrcFile((1 to 10).map(Tuple1.apply), path1)
    +    makeOrcFile((1 to 10).map(Tuple1.apply), path2)
    +    assertResult(20)(read.orc(path1.getCanonicalPath, path2.getCanonicalPath).count())
    --- End diff --
    
    `withOrcFile` will get cleaned up faster (e.g. as soon as the test ends rather than program exit).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org