You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/16 18:24:03 UTC
[GitHub] [incubator-tvm] bernhardklein opened a new pull request #6924: [AutoTVM][RPCRunner] timeout is not passed correctly
bernhardklein opened a new pull request #6924:
URL: https://github.com/apache/incubator-tvm/pull/6924
If we hand-over the timeout to the constructor of the LocalExecutor, like done in the LocalBuilder class it seems to solve the issue and the timeout is now correctly passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6924: [AutoTVM][RPCRunner] timeout is not passed correctly
Posted by GitBox <gi...@apache.org>.
merrymercy commented on a change in pull request #6924:
URL: https://github.com/apache/incubator-tvm/pull/6924#discussion_r525061819
##########
File path: python/tvm/autotvm/measure/measure_methods.py
##########
@@ -240,7 +240,7 @@ def __init__(
self.check_correctness = check_correctness
self.cooldown_interval = cooldown_interval
- self.executor = LocalExecutor()
+ self.executor = LocalExecutor(timeout=self.timeout)
Review comment:
```suggestion
self.executor = LocalExecutor(timeout=timeout * (self.n_parallel + 1 ))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] bernhardklein commented on pull request #6924: [AutoTVM][RPCRunner] timeout is not passed correctly
Posted by GitBox <gi...@apache.org>.
bernhardklein commented on pull request #6924:
URL: https://github.com/apache/incubator-tvm/pull/6924#issuecomment-728834693
@merrymercy as you suggested I set the constructor argument to `(timeout * (self.n_parallel + 1))`, also changed the self.timeout in the same way. Hope this is the correct way to do it. For `n_parallel=None` the base class Runner sets to cpu count, which seems to be working correctly. Hope now it's ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy edited a comment on pull request #6924: [AutoTVM][RPCRunner] timeout is not passed correctly
Posted by GitBox <gi...@apache.org>.
merrymercy edited a comment on pull request #6924:
URL: https://github.com/apache/incubator-tvm/pull/6924#issuecomment-728850614
You should only change the timeout setting in `LocalExecutor`.
The `self.timeout` is used in other places and it is correct.
I helped you to fix the problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy commented on pull request #6924: [AutoTVM][RPCRunner] timeout is not passed correctly
Posted by GitBox <gi...@apache.org>.
merrymercy commented on pull request #6924:
URL: https://github.com/apache/incubator-tvm/pull/6924#issuecomment-728850614
You should only change the timeout setting in `LocalExecutor`.
The `self.timeout` is used in other places and it is correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy edited a comment on pull request #6924: [AutoTVM][RPCRunner] timeout is not passed correctly
Posted by GitBox <gi...@apache.org>.
merrymercy edited a comment on pull request #6924:
URL: https://github.com/apache/incubator-tvm/pull/6924#issuecomment-728850614
You should only change the timeout setting in `LocalExecutor`.
The `self.timeout` is used in other places and it is correct.
I helped you fix the problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6924: [AutoTVM][RPCRunner] timeout is not passed correctly
Posted by GitBox <gi...@apache.org>.
merrymercy commented on a change in pull request #6924:
URL: https://github.com/apache/incubator-tvm/pull/6924#discussion_r525061557
##########
File path: python/tvm/autotvm/measure/measure_methods.py
##########
@@ -228,7 +228,7 @@ def __init__(
self.host = host
self.port = port
self.priority = priority
- self.timeout = timeout
+ self.timeout = timeout * (self.n_parallel + 1 )
Review comment:
```suggestion
self.timeout = timeout
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] bernhardklein commented on pull request #6924: [AutoTVM][RPCRunner] timeout is not passed correctly
Posted by GitBox <gi...@apache.org>.
bernhardklein commented on pull request #6924:
URL: https://github.com/apache/incubator-tvm/pull/6924#issuecomment-728878293
ok, thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6924: [AutoTVM][RPCRunner] timeout is not passed correctly
Posted by GitBox <gi...@apache.org>.
merrymercy commented on a change in pull request #6924:
URL: https://github.com/apache/incubator-tvm/pull/6924#discussion_r525064535
##########
File path: python/tvm/autotvm/measure/measure_methods.py
##########
@@ -240,7 +240,7 @@ def __init__(
self.check_correctness = check_correctness
self.cooldown_interval = cooldown_interval
- self.executor = LocalExecutor()
+ self.executor = LocalExecutor(timeout=timeout * (self.n_parallel + 1 ))
Review comment:
```suggestion
self.executor = LocalExecutor(timeout=timeout * (self.n_parallel + 1))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6924: [AutoTVM][RPCRunner] timeout is not passed correctly
Posted by GitBox <gi...@apache.org>.
merrymercy commented on a change in pull request #6924:
URL: https://github.com/apache/incubator-tvm/pull/6924#discussion_r525062032
##########
File path: python/tvm/autotvm/measure/measure_methods.py
##########
@@ -240,7 +240,7 @@ def __init__(
self.check_correctness = check_correctness
self.cooldown_interval = cooldown_interval
- self.executor = LocalExecutor()
+ self.executor = LocalExecutor(timeout=self.timeout)
Review comment:
```suggestion
self.executor = LocalExecutor(timeout=timeout * (self.n_parallel + 1 ))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy merged pull request #6924: [AutoTVM][RPCRunner] timeout is not passed correctly
Posted by GitBox <gi...@apache.org>.
merrymercy merged pull request #6924:
URL: https://github.com/apache/incubator-tvm/pull/6924
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] bernhardklein commented on pull request #6924: [AutoTVM][RPCRunner] timeout is not passed correctly
Posted by GitBox <gi...@apache.org>.
bernhardklein commented on pull request #6924:
URL: https://github.com/apache/incubator-tvm/pull/6924#issuecomment-728244254
relates to this [6924](https://github.com/apache/incubator-tvm/pull/6924) issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org