You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/08/21 22:10:36 UTC

[kudu-CR] [webui] Fancy tables for /maintenance-manager 

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11291


Change subject: [webui] Fancy tables for /maintenance-manager
......................................................................

[webui] Fancy tables for /maintenance-manager

Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
---
M www/maintenance-manager.mustache
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/11291/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Gerrit-Change-Number: 11291
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>

[kudu-CR] [webui] Fancy tables for /maintenance-manager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11291 )

Change subject: [webui] Fancy tables for /maintenance-manager
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Gerrit-Change-Number: 11291
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 22:25:25 +0000
Gerrit-HasComments: No

[kudu-CR] [webui] Fancy tables for /maintenance-manager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11291 )

Change subject: [webui] Fancy tables for /maintenance-manager
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Gerrit-Change-Number: 11291
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 22 Aug 2018 20:14:32 +0000
Gerrit-HasComments: No

[kudu-CR] [webui] Fancy tables for /maintenance-manager

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/11291 )

Change subject: [webui] Fancy tables for /maintenance-manager
......................................................................


Removed reviewer Kudu Jenkins.
-- 
To view, visit http://gerrit.cloudera.org:8080/11291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Gerrit-Change-Number: 11291
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [webui] Fancy tables for /maintenance-manager

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11291 )

Change subject: [webui] Fancy tables for /maintenance-manager
......................................................................


Patch Set 4: Verified+1

Skipping Jenkins since this was only rebased on an update to the parent.


-- 
To view, visit http://gerrit.cloudera.org:8080/11291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Gerrit-Change-Number: 11291
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 22:29:02 +0000
Gerrit-HasComments: No

[kudu-CR] [webui] Fancy tables for /maintenance-manager

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11291 )

Change subject: [webui] Fancy tables for /maintenance-manager
......................................................................


Patch Set 3:

13:56:13 [ 51%] Linking CXX executable ../../../bin/file_cache-stress-test
13:56:13 CMakeFiles/file_cache-stress-test.dir/file_cache-stress-test.cc.o: file not recognized: File truncated
13:56:13 collect2: error: ld returned 1 exit status

Funny error...second time I've seen it recently.


-- 
To view, visit http://gerrit.cloudera.org:8080/11291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Gerrit-Change-Number: 11291
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 21:53:23 +0000
Gerrit-HasComments: No

[kudu-CR] [webui] Fancy tables for /maintenance-manager

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11291 )

Change subject: [webui] Fancy tables for /maintenance-manager
......................................................................

[webui] Fancy tables for /maintenance-manager

Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Reviewed-on: http://gerrit.cloudera.org:8080/11291
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Will Berkeley <wd...@gmail.com>
---
M www/maintenance-manager.mustache
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Will Berkeley: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Gerrit-Change-Number: 11291
Gerrit-PatchSet: 5
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [webui] Fancy tables for /maintenance-manager

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11291 )

Change subject: [webui] Fancy tables for /maintenance-manager
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> 13:56:13 [ 51%] Linking CXX executable ../../../bin/file_cache-stress-test
> 13:56:13 CMakeFiles/file_cache-stress-test.dir/file_cache-stress-test.cc.o: file not recognized: File truncated
> 13:56:13 collect2: error: ld returned 1 exit status
> 
> Funny error...second time I've seen it recently.

I saw a couple of these earlier this week. I think some builds were aborted (or containers killed) abruptly, leaving these files behind in the workspaces.

We can clean out all of the workspaces, or just wait; these get deleted by the cleanup task that runs at the end of every kudu-gerrit job.


-- 
To view, visit http://gerrit.cloudera.org:8080/11291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Gerrit-Change-Number: 11291
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 21:56:54 +0000
Gerrit-HasComments: No

[kudu-CR] [webui] Fancy tables for /maintenance-manager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11291 )

Change subject: [webui] Fancy tables for /maintenance-manager
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Gerrit-Change-Number: 11291
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 22:09:35 +0000
Gerrit-HasComments: No

[kudu-CR] [webui] Fancy tables for /maintenance-manager

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11291 )

Change subject: [webui] Fancy tables for /maintenance-manager
......................................................................


Patch Set 3:

Thanks for the explanation, Adar. I wasn't sure what was going on.


-- 
To view, visit http://gerrit.cloudera.org:8080/11291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Gerrit-Change-Number: 11291
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 22:02:17 +0000
Gerrit-HasComments: No

[kudu-CR] [webui] Fancy tables for /maintenance-manager

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/11291 )

Change subject: [webui] Fancy tables for /maintenance-manager
......................................................................


Removed reviewer Kudu Jenkins.
-- 
To view, visit http://gerrit.cloudera.org:8080/11291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Gerrit-Change-Number: 11291
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [webui] Fancy tables for /maintenance-manager

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11291 )

Change subject: [webui] Fancy tables for /maintenance-manager
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Gerrit-Change-Number: 11291
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Aug 2018 21:53:38 +0000
Gerrit-HasComments: No

[kudu-CR] [webui] Fancy tables for /maintenance-manager

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed a vote on this change.

Change subject: [webui] Fancy tables for /maintenance-manager
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/11291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I725c13249b2cdc95fa674135c75b1414b2fc9047
Gerrit-Change-Number: 11291
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>