[GitHub] mik-laj commented on a change in pull request #4679: [Airflow-2840] - add update connection cli option

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #4679: [Airflow-2840] - add update connection cli option
URL: https://github.com/apache/airflow/pull/4679#discussion_r255336534
 
 

 ##########
 File path: airflow/api/client/api_client.py
 ##########
 @@ -69,3 +69,67 @@ def delete_pool(self, name):
         :param name: pool name
         """
         raise NotImplementedError()
+
+    def add_connection(self, conn_id,
+                       conn_uri=None,
+                       conn_type=None,
+                       conn_host=None,
+                       conn_login=None,
+                       conn_password=None,
+                       conn_schema=None,
+                       conn_port=None,
+                       conn_extra=None):
+        """
+
+        :param conn_id:
+        :param conn_uri:
+        :param conn_type:
+        :param conn_host:
+        :param conn_login:
+        :param conn_password:
+        :param conn_schema:
+        :param conn_port:
+        :param conn_extra:
+        :return: The new Connection
 
 Review comment:
   Missing  `rtype`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services