You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "iiiancampbell (via GitHub)" <gi...@apache.org> on 2024/05/13 14:18:11 UTC
[PR] Updated builder.rs [datafusion]
iiiancampbell opened a new pull request, #10487:
URL: https://github.com/apache/datafusion/pull/10487
Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc<LogicalPlan> #10485
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #10485 .
## Are these changes tested?
Covered by existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc #10485 [datafusion]
Posted by "iiiancampbell (via GitHub)" <gi...@apache.org>.
iiiancampbell commented on PR #10487:
URL: https://github.com/apache/datafusion/pull/10487#issuecomment-2109774656
Hm, apologies @yyy1000 , taking a look at some tests that could help here, wasn't sure which one was applicable though.
Tried `cargo test -p datafusion parquet_exec` which doesnt let builder.rs compile due to various lines expecting either 'LogicalPlan' or 'Arc<LogicalPlan>' or vice versa.
Could you point me in the correct direction by any chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc #10485 [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #10487: Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc<LogicalPlan> #10485
URL: https://github.com/apache/datafusion/pull/10487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc #10485 [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10487:
URL: https://github.com/apache/datafusion/pull/10487#issuecomment-2227586135
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc #10485 [datafusion]
Posted by "iiiancampbell (via GitHub)" <gi...@apache.org>.
iiiancampbell commented on PR #10487:
URL: https://github.com/apache/datafusion/pull/10487#issuecomment-2109205336
Oops , my bad, accidentally used 2 ","s to end the statement, I made my original commit late at night 😅 . My latest commit should pass all validation now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc #10485 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #10487:
URL: https://github.com/apache/datafusion/pull/10487#issuecomment-2113318965
Converting to draft as we work to fix CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc #10485 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #10487:
URL: https://github.com/apache/datafusion/pull/10487#issuecomment-2110982332
> Could you point me in the correct direction by any chance?
I think you will need to check out the code and make the relevant changes to get the code to compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc #10485 [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #10487:
URL: https://github.com/apache/datafusion/pull/10487#issuecomment-2107995895
Thanks @iiiancampbell ! I triggered the CI to start
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org