[jira] [Commented] (FINERACT-702) Integrate SpotBugs and fail build if equals but not hashCode is implemented

["Myrle Krantz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770355#comment-16770355 ] 

Myrle Krantz commented on FINERACT-702:
---------------------------------------

Perhaps @edcable knows of a volunteer who'd like to do this.

> Integrate SpotBugs and fail build if equals but not hashCode is implemented
> ---------------------------------------------------------------------------
>
>                 Key: FINERACT-702
>                 URL: https://issues.apache.org/jira/browse/FINERACT-702
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Michael Vorburger.ch
>            Priority: Major
>
> This project should activate SpotBugs (the successor to FindBugs) and make it fail the build for any violations to a at least a subset of rules which are almost always guaranteed to be bugs.
> For example, https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#he-class-defines-equals-and-uses-object-hashcode-he-equals-use-hashcode which would have caught what I manually spotted (but shouldn't have to) in https://github.com/apache/fineract/pull/524.
> FINERACT-402 has some history, but it's clearly not activated to enforce.
> FINERACT-696 could then be built on top of this.
> [~myrle] perhaps you know of any volunteer interested in doing this?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)