You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org> on 2017/03/20 17:47:07 UTC

Change in asterixdb[master]: Minor fix for the aws_start script.

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1599

Change subject: Minor fix for the aws_start script.
......................................................................

Minor fix for the aws_start script.

Change-Id: I7446868484a1ffd7ca84c3652276e69db5208498
---
M asterixdb/asterix-server/src/main/opt/aws/yaml/aws_start.yml
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/99/1599/1

diff --git a/asterixdb/asterix-server/src/main/opt/aws/yaml/aws_start.yml b/asterixdb/asterix-server/src/main/opt/aws/yaml/aws_start.yml
index 5287e34..344bfd5 100644
--- a/asterixdb/asterix-server/src/main/opt/aws/yaml/aws_start.yml
+++ b/asterixdb/asterix-server/src/main/opt/aws/yaml/aws_start.yml
@@ -29,8 +29,10 @@
   tasks:
     - include_vars: ../conf/aws_settings.yml
     - include_vars: ../conf/aws_types.yml
-    - debug:
-        msg: "{{ vols }}"
+
+    - name: Clean the temporary directory
+      shell: rm -rf "{{ temp_dir }}"
+
     - name: Launch all instances
       ec2:
         key_name: "{{ keypair }}"
@@ -110,7 +112,7 @@
 
     - name: Populate multiple iodevices
       shell: printf "  - /data{{ vol.0 + 1 }}/iodevice\n" >> "{{ temp_dir }}/devices"
-      with_indexed_items: vols
+      with_indexed_items: "{{ vols }}"
       loop_control:
         loop_var: vol
       when: vols|length > 0

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1599
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7446868484a1ffd7ca84c3652276e69db5208498
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>

Change in asterixdb[master]: Minor fix for the aws_start script.

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Minor fix for the aws_start script.
......................................................................


Patch Set 1: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/848/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1599
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7446868484a1ffd7ca84c3652276e69db5208498
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: Minor fix for the aws_start script.

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Minor fix for the aws_start script.
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4753/ (1/3)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1599
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7446868484a1ffd7ca84c3652276e69db5208498
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: Minor fix for the aws_start script.

Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has submitted this change and it was merged.

Change subject: Minor fix for the aws_start script.
......................................................................


Minor fix for the aws_start script.

Change-Id: I7446868484a1ffd7ca84c3652276e69db5208498
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1599
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
BAD: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ian Maxon <im...@apache.org>
---
M asterixdb/asterix-server/src/main/opt/aws/yaml/aws_start.yml
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Ian Maxon: Looks good to me, approved
  Jenkins: Verified; No violations found; No violations found; Verified



diff --git a/asterixdb/asterix-server/src/main/opt/aws/yaml/aws_start.yml b/asterixdb/asterix-server/src/main/opt/aws/yaml/aws_start.yml
index 5287e34..344bfd5 100644
--- a/asterixdb/asterix-server/src/main/opt/aws/yaml/aws_start.yml
+++ b/asterixdb/asterix-server/src/main/opt/aws/yaml/aws_start.yml
@@ -29,8 +29,10 @@
   tasks:
     - include_vars: ../conf/aws_settings.yml
     - include_vars: ../conf/aws_types.yml
-    - debug:
-        msg: "{{ vols }}"
+
+    - name: Clean the temporary directory
+      shell: rm -rf "{{ temp_dir }}"
+
     - name: Launch all instances
       ec2:
         key_name: "{{ keypair }}"
@@ -110,7 +112,7 @@
 
     - name: Populate multiple iodevices
       shell: printf "  - /data{{ vol.0 + 1 }}/iodevice\n" >> "{{ temp_dir }}/devices"
-      with_indexed_items: vols
+      with_indexed_items: "{{ vols }}"
       loop_control:
         loop_var: vol
       when: vols|length > 0

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1599
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7446868484a1ffd7ca84c3652276e69db5208498
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>

Change in asterixdb[master]: Minor fix for the aws_start script.

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Minor fix for the aws_start script.
......................................................................


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2253/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1599
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7446868484a1ffd7ca84c3652276e69db5208498
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: Minor fix for the aws_start script.

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Minor fix for the aws_start script.
......................................................................


Patch Set 1:

BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/848/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1599
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7446868484a1ffd7ca84c3652276e69db5208498
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: Minor fix for the aws_start script.

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Minor fix for the aws_start script.
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/74/ (2/3)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1599
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7446868484a1ffd7ca84c3652276e69db5208498
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: Minor fix for the aws_start script.

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Minor fix for the aws_start script.
......................................................................


Patch Set 1:

Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2253/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1599
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7446868484a1ffd7ca84c3652276e69db5208498
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: Minor fix for the aws_start script.

Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Ian Maxon has posted comments on this change.

Change subject: Minor fix for the aws_start script.
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1599
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7446868484a1ffd7ca84c3652276e69db5208498
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No