You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by ma...@apache.org on 2001/03/09 09:29:04 UTC
cvs commit: apr-util configure.in
martin 01/03/09 00:29:03
Modified: . configure.in
Log:
Make Makefile in xml/expat
Revision Changes Path
1.13 +1 -0 apr-util/configure.in
Index: configure.in
===================================================================
RCS file: /home/cvs/apr-util/configure.in,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -u -r1.12 -r1.13
--- configure.in 2001/02/24 14:17:24 1.12
+++ configure.in 2001/03/09 08:29:03 1.13
@@ -93,5 +93,6 @@
hooks/Makefile
uri/Makefile
xml/Makefile
+ xml/expat/Makefile
$test_Makefile
])
Re: cvs commit: apr-util configure.in
Posted by rb...@covalent.net.
On Fri, 9 Mar 2001, Greg Stein wrote:
> That is probably the stupid dependency stuff in build2.mk. httpd's buildconf
> should unconditionally recurse.
>
> But Martin's error is something else, I believe (see other note). I'm
> testing a fix now.
Okay, and that fix needs to go in (I mentioned it in my commit log in
fact), but when I hit this bug, it was fixed by doing a buildconf in
srclib/apr and srclib/apr-util.
Ryan
>
> Cheers,
> -g
>
> On Fri, Mar 09, 2001 at 06:25:40AM -0800, rbb@covalent.net wrote:
> >
> > I have found recently, that buildconf doesn't really do what you expect in
> > a lot of cases. Namely, it doesn't tend to traverse into srclib/apr and
> > srclib/apr-util, and run those buildconf's. Try running those manually
> > right now. I was going to investigate further before posting the bug, but
> > time isn't being kind to me. :-)
> >
> > Ryan
> >
> > On Fri, 9 Mar 2001, Martin Kraemer wrote:
> >
> > > On Fri, Mar 09, 2001 at 05:06:25AM -0800, Greg Stein wrote:
> > > > No.
> > > >
> > > > We run xml/expat/configure, and it produces that Makefile. APRUTIL shouldn't
> > > > be doing this. Please back out this change.
> > >
> > > That is not really true. It definitely did not generate the Makefile,
> > > that's why I added the patch in the first place.
> > >
> > > I always do "buildconf && configure && make clean && make",
> > > and "make clean" bailed out because the apr-util/xml/expat/Makefile
> > > was not generated.
> > >
> > > Martin.
> > > --
> > > <Ma...@Fujitsu-Siemens.com> | Fujitsu Siemens
> > > Fon: +49-89-636-46021, FAX: +49-89-636-41143 | 81730 Munich, Germany
> > >
> > >
> >
> >
> > _______________________________________________________________________________
> > Ryan Bloom rbb@apache.org
> > 406 29th St.
> > San Francisco, CA 94131
> > -------------------------------------------------------------------------------
>
> --
> Greg Stein, http://www.lyra.org/
>
>
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: cvs commit: apr-util configure.in
Posted by Greg Stein <gs...@lyra.org>.
That is probably the stupid dependency stuff in build2.mk. httpd's buildconf
should unconditionally recurse.
But Martin's error is something else, I believe (see other note). I'm
testing a fix now.
Cheers,
-g
On Fri, Mar 09, 2001 at 06:25:40AM -0800, rbb@covalent.net wrote:
>
> I have found recently, that buildconf doesn't really do what you expect in
> a lot of cases. Namely, it doesn't tend to traverse into srclib/apr and
> srclib/apr-util, and run those buildconf's. Try running those manually
> right now. I was going to investigate further before posting the bug, but
> time isn't being kind to me. :-)
>
> Ryan
>
> On Fri, 9 Mar 2001, Martin Kraemer wrote:
>
> > On Fri, Mar 09, 2001 at 05:06:25AM -0800, Greg Stein wrote:
> > > No.
> > >
> > > We run xml/expat/configure, and it produces that Makefile. APRUTIL shouldn't
> > > be doing this. Please back out this change.
> >
> > That is not really true. It definitely did not generate the Makefile,
> > that's why I added the patch in the first place.
> >
> > I always do "buildconf && configure && make clean && make",
> > and "make clean" bailed out because the apr-util/xml/expat/Makefile
> > was not generated.
> >
> > Martin.
> > --
> > <Ma...@Fujitsu-Siemens.com> | Fujitsu Siemens
> > Fon: +49-89-636-46021, FAX: +49-89-636-41143 | 81730 Munich, Germany
> >
> >
>
>
> _______________________________________________________________________________
> Ryan Bloom rbb@apache.org
> 406 29th St.
> San Francisco, CA 94131
> -------------------------------------------------------------------------------
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: apr-util configure.in
Posted by Greg Stein <gs...@lyra.org>.
On Fri, Mar 09, 2001 at 03:01:36PM +0100, Martin Kraemer wrote:
> On Fri, Mar 09, 2001 at 05:06:25AM -0800, Greg Stein wrote:
> > No.
> >
> > We run xml/expat/configure, and it produces that Makefile. APRUTIL shouldn't
> > be doing this. Please back out this change.
>
> That is not really true. It definitely did not generate the Makefile,
> that's why I added the patch in the first place.
>
> I always do "buildconf && configure && make clean && make",
> and "make clean" bailed out because the apr-util/xml/expat/Makefile
> was not generated.
A snippet of my configuration log:
updating cache ../../../.././config.cache
creating ./config.status
creating Makefile
creating lib/Makefile
creating lib/expat.h
creating config.h
xml/expat configured properly
I see the Makefile getting created there :-)
... I figured out the problem. In the APRUTIL configuration, you'll see some
lines like this:
checking for Expat in /usr... no
checking for Expat in /usr/local... no
checking for Expat in xml/expat-cvs... no
checking for Expat in xml/expat... yes
What are you seeing on your platform? I'm guessing that Expat was installed
and found in one of those other locations. Thus, aprutil's configure never
ran xml/expat/configure, thus never making xml/expat/Makefile.
Prolly the same for David.
The right answer is to fix xml/Makefile.in to recurse only if APRUTIL
decides to use its builtin expat.
Fix approacheth...
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: apr-util configure.in
Posted by rb...@covalent.net.
I have found recently, that buildconf doesn't really do what you expect in
a lot of cases. Namely, it doesn't tend to traverse into srclib/apr and
srclib/apr-util, and run those buildconf's. Try running those manually
right now. I was going to investigate further before posting the bug, but
time isn't being kind to me. :-)
Ryan
On Fri, 9 Mar 2001, Martin Kraemer wrote:
> On Fri, Mar 09, 2001 at 05:06:25AM -0800, Greg Stein wrote:
> > No.
> >
> > We run xml/expat/configure, and it produces that Makefile. APRUTIL shouldn't
> > be doing this. Please back out this change.
>
> That is not really true. It definitely did not generate the Makefile,
> that's why I added the patch in the first place.
>
> I always do "buildconf && configure && make clean && make",
> and "make clean" bailed out because the apr-util/xml/expat/Makefile
> was not generated.
>
> Martin.
> --
> <Ma...@Fujitsu-Siemens.com> | Fujitsu Siemens
> Fon: +49-89-636-46021, FAX: +49-89-636-41143 | 81730 Munich, Germany
>
>
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: cvs commit: apr-util configure.in
Posted by Martin Kraemer <Ma...@Fujitsu-Siemens.com>.
On Fri, Mar 09, 2001 at 05:06:25AM -0800, Greg Stein wrote:
> No.
>
> We run xml/expat/configure, and it produces that Makefile. APRUTIL shouldn't
> be doing this. Please back out this change.
That is not really true. It definitely did not generate the Makefile,
that's why I added the patch in the first place.
I always do "buildconf && configure && make clean && make",
and "make clean" bailed out because the apr-util/xml/expat/Makefile
was not generated.
Martin.
--
<Ma...@Fujitsu-Siemens.com> | Fujitsu Siemens
Fon: +49-89-636-46021, FAX: +49-89-636-41143 | 81730 Munich, Germany
Re: cvs commit: apr-util configure.in
Posted by David Reid <dr...@jetnet.co.uk>.
This change gets things building for me on BeOS...
david
> No.
>
> We run xml/expat/configure, and it produces that Makefile. APRUTIL
shouldn't
> be doing this. Please back out this change.
>
> -g
>
> On Fri, Mar 09, 2001 at 08:29:04AM -0000, martin@apache.org wrote:
> > martin 01/03/09 00:29:03
> >
> > Modified: . configure.in
> > Log:
> > Make Makefile in xml/expat
> >
> > Revision Changes Path
> > 1.13 +1 -0 apr-util/configure.in
> >
> > Index: configure.in
> > ===================================================================
> > RCS file: /home/cvs/apr-util/configure.in,v
> > retrieving revision 1.12
> > retrieving revision 1.13
> > diff -u -u -r1.12 -r1.13
> > --- configure.in 2001/02/24 14:17:24 1.12
> > +++ configure.in 2001/03/09 08:29:03 1.13
> > @@ -93,5 +93,6 @@
> > hooks/Makefile
> > uri/Makefile
> > xml/Makefile
> > + xml/expat/Makefile
> > $test_Makefile
> > ])
> >
> >
> >
>
> --
> Greg Stein, http://www.lyra.org/
>
Re: cvs commit: apr-util configure.in
Posted by Greg Stein <gs...@lyra.org>.
No.
We run xml/expat/configure, and it produces that Makefile. APRUTIL shouldn't
be doing this. Please back out this change.
-g
On Fri, Mar 09, 2001 at 08:29:04AM -0000, martin@apache.org wrote:
> martin 01/03/09 00:29:03
>
> Modified: . configure.in
> Log:
> Make Makefile in xml/expat
>
> Revision Changes Path
> 1.13 +1 -0 apr-util/configure.in
>
> Index: configure.in
> ===================================================================
> RCS file: /home/cvs/apr-util/configure.in,v
> retrieving revision 1.12
> retrieving revision 1.13
> diff -u -u -r1.12 -r1.13
> --- configure.in 2001/02/24 14:17:24 1.12
> +++ configure.in 2001/03/09 08:29:03 1.13
> @@ -93,5 +93,6 @@
> hooks/Makefile
> uri/Makefile
> xml/Makefile
> + xml/expat/Makefile
> $test_Makefile
> ])
>
>
>
--
Greg Stein, http://www.lyra.org/