You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/07 02:47:32 UTC

[GitHub] [airflow] BobDu commented on a diff in pull request #27480: fix flower_url_prefix

BobDu commented on code in PR #27480:
URL: https://github.com/apache/airflow/pull/27480#discussion_r1014960673


##########
chart/values.yaml:
##########
@@ -1695,7 +1695,7 @@ config:
     # For Airflow 1.10
     rbac: 'True'
   celery:
-    flower_url_prefix: '{{ .Values.ingress.flower.path }}'
+    flower_url_prefix: ''

Review Comment:
   > But it will always select .Values.ingress.flower.path if it is not empty. That means, it will select "/" always which doesn't work. url_prefix should be "" instead. Is that correct?
   
   Agree it. `{{ .Values.ingress.flower.path | default "" }` may not work. Because `.Values.ingress.flower.path` default value must be `/`, can not use empty string.
   ref: https://github.com/apache/airflow/pull/27472#pullrequestreview-1166214946
   @XD-DENG 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org