You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:17:39 UTC

[GitHub] [kafka] cmccabe commented on pull request #10891: MINOR: Add reset to SnapshotRegistry and Revertable

cmccabe commented on pull request #10891:
URL: https://github.com/apache/kafka/pull/10891#issuecomment-863427969


   Thanks, @jsancio . I like the concept here.
   
   For now, I think it's OK to have TimelineInteger and TimelineLong always "reset" to 0. All the uses we have now have that behavior. Maybe we can avoid storing the "init" value if nobody needs a value other than 0 (yet?).
   
   I think "reset" should be basically identical to the constructor for the hash table(s).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org