You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "amaechler (via GitHub)" <gi...@apache.org> on 2026/06/17 12:09:44 UTC

[PR] test: Fix flaky `BasicAuthMSQTest` (druid)

amaechler opened a new pull request, #19593:
URL: https://github.com/apache/druid/pull/19593

   ### Description
   
   `BasicAuthMSQTest` is intermittently flaky: a test occasionally fails with `401 Unauthorized` instead of the expected `403 Forbidden`.
   
   The permission updates in the tests are eventually consistent, but propagate to other services (like the broker) asynchronously, so the MSQ task in the test can reach the Broker before its auth cache has caught up.
   
   ### Fix
   
   Retry the task submission while it fails with a transient auth errors, so the assertions only run once the Broker's auth cache reflects the test setup. Other failures are not retried, so genuine errors still fail fast. This follows the retry-on-propagation pattern already used by sibling tests (e.g. `TLSTest`).
   
   Verified by compiling, running checkstyle, and running the test; a fault-injection run that forces a transient `401` then `403` confirms the retries fire and all four tests recover.
   
   _Analysis and implementation done with the help of Claude Code._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] test: Fix flaky `BasicAuthMSQTest` (druid)

Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz merged PR #19593:
URL: https://github.com/apache/druid/pull/19593


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org