You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Gary-Hobson (via GitHub)" <gi...@apache.org> on 2026/01/22 11:36:52 UTC
[PR] arch/arm64: fix backtrace return address precision [nuttx]
Gary-Hobson opened a new pull request, #18106:
URL: https://github.com/apache/nuttx/pull/18106
## Summary
This PR fixes the backtrace return address precision issue on ARM64 architecture.
The return address stored in the frame points to the instruction after the call. To accurately identify the call site, we need to subtract the instruction size (sizeof(void *)) from the saved return address.
## Impact
This ensures that backtrace addresses correctly point to the calling instruction rather than the next instruction, improving debugging accuracy.
## Testing
Tested on ARM64 platform and verified that backtrace addresses now correctly point to the actual call sites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm64: fix backtrace return address precision [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #18106:
URL: https://github.com/apache/nuttx/pull/18106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm64: fix backtrace return address precision [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #18106:
URL: https://github.com/apache/nuttx/pull/18106#issuecomment-3783993974
> @Gary-Hobson could you please update https://nuttx.apache.org/docs/latest/applications/system/dumpstack/index.html I just noticed it is empty
Please consider including this stack layout diagram there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm64: fix backtrace return address precision [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #18106:
URL: https://github.com/apache/nuttx/pull/18106#issuecomment-3784691917
@Gary-Hobson please fix:
```
../nuttx/tools/checkpatch.sh -c -u -m -g 702e1d95f32ffd9b7189eb302e7e53ba9599516c..HEAD
❌ Missing git commit message
Used config files:
1: .codespellrc
Some checks failed. For contributing guidelines, see:
https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm64: fix backtrace return address precision [nuttx]
Posted by "Gary-Hobson (via GitHub)" <gi...@apache.org>.
Gary-Hobson commented on PR #18106:
URL: https://github.com/apache/nuttx/pull/18106#issuecomment-3788700134
> @Gary-Hobson please fix:
>
> ```
> ../nuttx/tools/checkpatch.sh -c -u -m -g 702e1d95f32ffd9b7189eb302e7e53ba9599516c..HEAD
> ❌ Missing git commit message
> Used config files:
> 1: .codespellrc
> Some checks failed. For contributing guidelines, see:
> https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
> ```
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm64: fix backtrace return address precision [nuttx]
Posted by "Gary-Hobson (via GitHub)" <gi...@apache.org>.
Gary-Hobson commented on PR #18106:
URL: https://github.com/apache/nuttx/pull/18106#issuecomment-3784204544
> > @Gary-Hobson could you please update https://nuttx.apache.org/docs/latest/applications/system/dumpstack/index.html I just noticed it is empty
>
> Please consider including this stack layout diagram there
The documentation has been added, but I don't think the stack layout is suitable to be included. The stack layout and the method for obtaining a backtrace vary by architecture. Including these details in the documentation is too specific( and I only have a limited understanding of the ARM-related content myself)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org