You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "fjtirado (via GitHub)" <gi...@apache.org> on 2025/02/06 20:13:52 UTC
[PR] [Fix #3813] Allowing configuration of output topic for internal events [incubator-kie-kogito-runtimes]
fjtirado opened a new pull request, #3840:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3840
Fix https://github.com/apache/incubator-kie-kogito-runtimes/issues/3813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #3813] Allowing configuration of output topic for internal events [incubator-kie-kogito-runtimes]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado closed pull request #3840: [Fix #3813] Allowing configuration of output topic for internal events
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #3813] Allowing configuration of output topic for internal events [incubator-kie-kogito-runtimes]
Posted by "gmunozfe (via GitHub)" <gi...@apache.org>.
gmunozfe commented on PR #3840:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3840#issuecomment-2642441354
Looks good to me, `kogito.events.usertaskinstances.topic` might also work, but it's fine as it is.
Good work @fjtirado !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #3813] Removing Quarkus Configuration From Springboot file [incubator-kie-kogito-runtimes]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado merged PR #3840:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #3813] Allowing configuration of output topic for internal events [incubator-kie-kogito-runtimes]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on PR #3840:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3840#issuecomment-2643486192
As @pefernan realized, events are already configurable by using kogito.addon.events.process.kafka.kogito-processinstances-events.topic=the topic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #3813] Allowing configuration of output topic for internal events [incubator-kie-kogito-runtimes]
Posted by "pefernan (via GitHub)" <gi...@apache.org>.
pefernan commented on code in PR #3840:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3840#discussion_r1946913592
##########
springboot/integration-tests/integration-tests-springboot-kafka-it/src/main/resources/application.properties:
##########
@@ -27,13 +27,8 @@ spring.kafka.producer.value-serializer=org.apache.kafka.common.serialization.Str
# read/write on the same topic
kogito.addon.cloudevents.kafka.kogito_outgoing_stream=pingpong
kogito.addon.cloudevents.kafka.kogito_incoming_stream=pingpong
+
# Kogito events
-mp.messaging.outgoing.kogito-processinstances-events.connector=smallrye-kafka
-mp.messaging.outgoing.kogito-processinstances-events.topic=kogito-processinstances-events
-mp.messaging.outgoing.kogito-processinstances-events.value.serializer=org.apache.kafka.common.serialization.StringSerializer
-mp.messaging.outgoing.kogito-usertaskinstances-events.connector=smallrye-kafka
-mp.messaging.outgoing.kogito-usertaskinstances-events.topic=kogito-usertaskinstances-events
-mp.messaging.outgoing.kogito-usertaskinstances-events.value.serializer=org.apache.kafka.common.serialization.StringSerializer
-mp.messaging.outgoing.kogito-variables-events.connector=smallrye-kafka
-mp.messaging.outgoing.kogito-variables-events.topic=kogito-variables-events
-mp.messaging.outgoing.kogito-variables-events.value.serializer=org.apache.kafka.common.serialization.StringSerializer
\ No newline at end of file
+kogito.addon.events.process.kafka.kogito-processinstances-events.topic=kogito-processinstances-events
+kogito.addon.events.process.kafka.kogito-processdefinitions-events.topic=kogito-processdefinitions-events
Review Comment:
There's a blank space at the end :)
```suggestion
kogito.addon.events.process.kafka.kogito-processdefinitions-events.topic=kogito-processdefinitions-events
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #3813] Removing Quarkus Configuration From Springboot file [incubator-kie-kogito-runtimes]
Posted by "pefernan (via GitHub)" <gi...@apache.org>.
pefernan commented on PR #3840:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3840#issuecomment-2643585139
Perfect man :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #3813] Removing Quarkus Configuration From Springboot file [incubator-kie-kogito-runtimes]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3840:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3840#issuecomment-2644073803
**PR job** `#10` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3840 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3840/10/display/redirect
**Test results:**
- PASSED: 3544
- FAILED: 1
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3840/10/testReport/org.kie.kogito.codegen.tests/PublishEventIT/testExclusiveGatewayStartToEnd/">org.kie.kogito.codegen.tests.PublishEventIT.testExclusiveGatewayStartToEnd</a></summary>
<br/>expected: "ExclusiveSplit"<br/> but was: "defaultPackage.TimerProcess"
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org