[GitHub] [pinot] vishwa35 commented on a change in pull request #7252: support ST_Contains with H3 optimization

[GitBox <gi...@apache.org>]

vishwa35 commented on a change in pull request #7252:
URL: https://github.com/apache/pinot/pull/7252#discussion_r683784229



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/StContainsFunction.java
##########
@@ -83,9 +82,6 @@ public TransformResultMetadata getResultMetadata() {
     for (int i = 0; i < projectionBlock.getNumDocs(); i++) {
       Geometry firstGeometry = GeometrySerializer.deserialize(firstValues[i]);
       Geometry secondGeometry = GeometrySerializer.deserialize(secondValues[i]);
-      if (GeometryUtils.isGeography(firstGeometry) || GeometryUtils.isGeography(secondGeometry)) {

Review comment:
       why does it not work for geography?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org