You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "debiswal (via GitHub)" <gi...@apache.org> on 2023/02/08 02:31:07 UTC
[GitHub] [ozone] debiswal opened a new pull request, #4256: Code changes for Sorting,Searching & Pagination on SCM UI
debiswal opened a new pull request, #4256:
URL: https://github.com/apache/ozone/pull/4256
## PR Changes:
This Includes Sorting, Searching & Pagination on SCM UI where page deafult size is 10. we can also set this to 20 or 50 records per page as well.
Page slicing & Record Slicing both have been implemented along wth sort & search.
JIRA link : https://jira.cloudera.com/browse/CDPD-47855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] debiswal commented on a diff in pull request #4256: HDDS-7816. Add DataNode list to the SCM WebUI
Posted by "debiswal (via GitHub)" <gi...@apache.org>.
debiswal commented on code in PR #4256:
URL: https://github.com/apache/ozone/pull/4256#discussion_r1108390589
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html:
##########
@@ -28,25 +28,53 @@ <h2>SCM Information</h2>
</tbody>
</table>
-<h2>Node counts</h2>
-
-<table class="table table-bordered table-striped" class="col-md-6">
+<h2>Node Status</h2>
+<div class="row">
+ <div class="col-md-6 text-left">
+ <label>Show: </label>
+ <select class="form-select" ng-model="RecordsToDisplay" ng-change="UpdateRecordsToShow()">
+ <option value="10" ng-selected="{true}">10</option>
+ <option value="20">20</option>
+ <option value="50">50</option>
Review Comment:
commit id : b99acf9c78e7b8b7cbdb64d609aa14bf8fcad8e9
this commit includes option 'All' added in SCM UI for user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] debiswal commented on a diff in pull request #4256: HDDS-7816. Add DataNode list to the SCM WebUI
Posted by "debiswal (via GitHub)" <gi...@apache.org>.
debiswal commented on code in PR #4256:
URL: https://github.com/apache/ozone/pull/4256#discussion_r1108391363
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm.js:
##########
@@ -24,12 +24,46 @@
require: {
overview: "^overview"
},
- controller: function ($http) {
+ controller: function ($http,$scope) {
var ctrl = this;
+ $scope.reverse=true;
+ $scope.columnName="";
+ let nodeStatusCopy=[];
+ $scope.RecordsToDisplay ="10";
+ $scope.currentPage=1;
+ $scope.lastIndex = 0;
+
$http.get("jmx?qry=Hadoop:service=SCMNodeManager,name=SCMNodeManagerInfo")
.then(function (result) {
ctrl.nodemanagermetrics = result.data.beans[0];
- });
+ $scope.nodeStatus = ctrl.nodemanagermetrics && ctrl.nodemanagermetrics.NodeStatus && ctrl.nodemanagermetrics.NodeStatus.map(({ key, value}) =>{
Review Comment:
Indentation has been fixed as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] debiswal commented on pull request #4256: HDDS-7816. Add DataNode list to the SCM WebUI
Posted by "debiswal (via GitHub)" <gi...@apache.org>.
debiswal commented on PR #4256:
URL: https://github.com/apache/ozone/pull/4256#issuecomment-1436533016
Closing this PR due to unrelated commits as new PR has been raised .
**New PR Link :**
https://github.com/apache/ozone/pull/4289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] debiswal closed pull request #4256: HDDS-7816. Add DataNode list to the SCM WebUI
Posted by "debiswal (via GitHub)" <gi...@apache.org>.
debiswal closed pull request #4256: HDDS-7816. Add DataNode list to the SCM WebUI
URL: https://github.com/apache/ozone/pull/4256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4256: Code changes for Sorting,Searching & Pagination on SCM UI
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4256:
URL: https://github.com/apache/ozone/pull/4256#issuecomment-1422303438
@debiswal Thanks for the patch.
Please [request an account](https://infra.apache.org/jira-guidelines.html#who) for [Apache Jira](https://issues.apache.org/jira/) (project you need to substitute in the email address is `ozone`). When your Jira account is created, please file an [HDDS issue](https://issues.apache.org/jira/browse/HDDS) and link it in the PR description. Also update the PR title to include the Jira issue ID in `HDDS-1234. ` format as a prefix.
Also, please include in the PR description information on how the change was tested. Since it's a UI change, I assume it was tested manually. Please include some screenshot for reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4256: HDDS-7816. Add DataNode list to the SCM WebUI
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4256:
URL: https://github.com/apache/ozone/pull/4256#issuecomment-1435654633
@debiswal This PR has unrelated commits from other contributors. If you want to update your branch, please merge `master` into it instead of cherry-picking individual commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta commented on a diff in pull request #4256: HDDS-7816. Add DataNode list to the SCM WebUI
Posted by "fapifta (via GitHub)" <gi...@apache.org>.
fapifta commented on code in PR #4256:
URL: https://github.com/apache/ozone/pull/4256#discussion_r1101624773
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html:
##########
@@ -28,25 +28,53 @@ <h2>SCM Information</h2>
</tbody>
</table>
-<h2>Node counts</h2>
-
-<table class="table table-bordered table-striped" class="col-md-6">
+<h2>Node Status</h2>
+<div class="row">
+ <div class="col-md-6 text-left">
+ <label>Show: </label>
+ <select class="form-select" ng-model="RecordsToDisplay" ng-change="UpdateRecordsToShow()">
+ <option value="10" ng-selected="{true}">10</option>
+ <option value="20">20</option>
+ <option value="50">50</option>
Review Comment:
Can we add the option "All" here as well? As we get all the nodes, and all the paging happens on the client side, I think it might be reasonable to enable the users to show all the nodes as well.
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm.js:
##########
@@ -24,12 +24,46 @@
require: {
overview: "^overview"
},
- controller: function ($http) {
+ controller: function ($http,$scope) {
var ctrl = this;
+ $scope.reverse=true;
+ $scope.columnName="";
+ let nodeStatusCopy=[];
+ $scope.RecordsToDisplay ="10";
+ $scope.currentPage=1;
+ $scope.lastIndex = 0;
+
$http.get("jmx?qry=Hadoop:service=SCMNodeManager,name=SCMNodeManagerInfo")
.then(function (result) {
ctrl.nodemanagermetrics = result.data.beans[0];
- });
+ $scope.nodeStatus = ctrl.nodemanagermetrics && ctrl.nodemanagermetrics.NodeStatus && ctrl.nodemanagermetrics.NodeStatus.map(({ key, value}) =>{
Review Comment:
From this point on indentation seems to be shifted and a bit ad-hoc, please fix that, and also please go over the file, and fix missing spaces here and there (around = sign, after { and before }, after ,)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta commented on pull request #4256: HDDS-7816. Add DataNode list to the SCM WebUI
Posted by "fapifta (via GitHub)" <gi...@apache.org>.
fapifta commented on PR #4256:
URL: https://github.com/apache/ozone/pull/4256#issuecomment-1424283193
@adoroszlai thank you for the suggestions, Deb already has the JIRA account, and we had the upstream JIRA, I believe it was just mixed up with some internal tracking.
@debiswal I think there is a misunderstanding here a bit. In order to make the table work, we need the backend code as well as the frontend code changes, as they have to be committed together.
Please add the changes in the underlying backend code, so we can evaluate the two together.
Backend changes for the current state of the UI as we discussed are ready, and as a next step HDDS-7817 will add the HTTP and HTTPS port for the backend, and then we can expose that to the frontend as well in a follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org