[GitHub] [linkis] jackxu2011 commented on a diff in pull request #4295: fix python watch dog not work

["jackxu2011 (via GitHub)" <gi...@apache.org>]

jackxu2011 commented on code in PR #4295:
URL: https://github.com/apache/linkis/pull/4295#discussion_r1125840177


##########
linkis-engineconn-plugins/spark/src/main/scala/org/apache/linkis/engineplugin/spark/executor/SparkPythonExecutor.scala:
##########
@@ -126,7 +126,7 @@ class SparkPythonExecutor(val sparkEngineSession: SparkEngineSession, val id: In
         // process.destroy will kills the subprocess,not need to force kill with -9,
         // kill -9 may cause resources not to be released
         pid.foreach(p => {
-          logger.info(s"skip Try to kill Pyspark process with: [kill -9 ${p}]")
+          logger.info(s"skip Try to kill Pyspark process with: [kill -15 ${p}]")
           Utils.exec(Array("kill", "-9", p), 3000L)

Review Comment:
   the log is kill -15, but the exec cmd is kill -9



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org