You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by mc...@apache.org on 2008/01/31 19:00:40 UTC
svn commit: r617174 - in /myfaces/trinidad/trunk/trinidad-impl/src:
main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/
test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/
Author: mcooper
Date: Thu Jan 31 10:00:26 2008
New Revision: 617174
URL: http://svn.apache.org/viewvc?rev=617174&view=rev
Log:
TRINIDAD-927 panelBox with an icon or title does not support stretching to 100% width.
The panelBox without an icon and title will support stretching of its contents to be 100% wide when you have an inlineStyle="width:100%;". However, if you have either an icon or title text present, there is a table element that wraps the header and content and this table didn't have its width set to 100%. Now, both scenarios will support being 100% wide.
Modified:
myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelBoxRenderer.java
myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimal-golden.xml
myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalIE-golden.xml
myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalIERtl-golden.xml
myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalInacc-golden.xml
myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalPPC-golden.xml
myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalSaf-golden.xml
myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalScrRdr-golden.xml
Modified: myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelBoxRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelBoxRenderer.java?rev=617174&r1=617173&r2=617174&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelBoxRenderer.java (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/PanelBoxRenderer.java Thu Jan 31 10:00:26 2008
@@ -306,7 +306,7 @@
{
// There's both a header and a content, use a table.
writer.startElement(XhtmlConstants.TABLE_ELEMENT, null);
- OutputUtils.renderLayoutTableAttributes(context, arc, "0", null);
+ OutputUtils.renderLayoutTableAttributes(context, arc, "0", "100%");
writer.startElement(XhtmlConstants.TABLE_BODY_ELEMENT, null);
// Render header
Modified: myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimal-golden.xml
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimal-golden.xml?rev=617174&r1=617173&r2=617174&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimal-golden.xml (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimal-golden.xml Thu Jan 31 10:00:26 2008
@@ -647,6 +647,7 @@
cellpadding="0"
cellspacing="0"
summary=""
+ width="100%"
>
<tbody
@@ -798,6 +799,7 @@
cellpadding="0"
cellspacing="0"
summary=""
+ width="100%"
>
<tbody
Modified: myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalIE-golden.xml
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalIE-golden.xml?rev=617174&r1=617173&r2=617174&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalIE-golden.xml (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalIE-golden.xml Thu Jan 31 10:00:26 2008
@@ -647,6 +647,7 @@
cellpadding="0"
cellspacing="0"
summary=""
+ width="100%"
>
<tbody
@@ -798,6 +799,7 @@
cellpadding="0"
cellspacing="0"
summary=""
+ width="100%"
>
<tbody
Modified: myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalIERtl-golden.xml
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalIERtl-golden.xml?rev=617174&r1=617173&r2=617174&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalIERtl-golden.xml (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalIERtl-golden.xml Thu Jan 31 10:00:26 2008
@@ -647,6 +647,7 @@
cellpadding="0"
cellspacing="0"
summary=""
+ width="100%"
>
<tbody
@@ -798,6 +799,7 @@
cellpadding="0"
cellspacing="0"
summary=""
+ width="100%"
>
<tbody
Modified: myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalInacc-golden.xml
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalInacc-golden.xml?rev=617174&r1=617173&r2=617174&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalInacc-golden.xml (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalInacc-golden.xml Thu Jan 31 10:00:26 2008
@@ -640,6 +640,7 @@
border="0"
cellpadding="0"
cellspacing="0"
+ width="100%"
>
<tbody
@@ -789,6 +790,7 @@
border="0"
cellpadding="0"
cellspacing="0"
+ width="100%"
>
<tbody
Modified: myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalPPC-golden.xml
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalPPC-golden.xml?rev=617174&r1=617173&r2=617174&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalPPC-golden.xml (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalPPC-golden.xml Thu Jan 31 10:00:26 2008
@@ -647,6 +647,7 @@
cellpadding="0"
cellspacing="0"
summary=""
+ width="100%"
>
<tbody
@@ -798,6 +799,7 @@
cellpadding="0"
cellspacing="0"
summary=""
+ width="100%"
>
<tbody
Modified: myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalSaf-golden.xml
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalSaf-golden.xml?rev=617174&r1=617173&r2=617174&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalSaf-golden.xml (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalSaf-golden.xml Thu Jan 31 10:00:26 2008
@@ -647,6 +647,7 @@
cellpadding="0"
cellspacing="0"
summary=""
+ width="100%"
>
<tbody
@@ -798,6 +799,7 @@
cellpadding="0"
cellspacing="0"
summary=""
+ width="100%"
>
<tbody
Modified: myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalScrRdr-golden.xml
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalScrRdr-golden.xml?rev=617174&r1=617173&r2=617174&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalScrRdr-golden.xml (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/renderkit/golden/panelBox-minimalScrRdr-golden.xml Thu Jan 31 10:00:26 2008
@@ -647,6 +647,7 @@
cellpadding="0"
cellspacing="0"
summary=""
+ width="100%"
>
<tbody
@@ -798,6 +799,7 @@
cellpadding="0"
cellspacing="0"
summary=""
+ width="100%"
>
<tbody