You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by "Simon Willnauer (Resolved) (JIRA)" <ji...@apache.org> on 2011/11/10 05:03:52 UTC

[jira] [Resolved] (LUCENE-2564) wordlistloader is inefficient

     [ https://issues.apache.org/jira/browse/LUCENE-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer resolved LUCENE-2564.
-------------------------------------

       Resolution: Fixed
    Lucene Fields: New,Patch Available  (was: New)

committed to trunk and backported to 3.x
                
> wordlistloader is inefficient
> -----------------------------
>
>                 Key: LUCENE-2564
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2564
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/analysis
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-2564.patch, LUCENE-2564.patch, LUCENE-2564.patch
>
>
> WordListLoader is basically used for loading up stopwords lists, stem dictionaries, etc.
> Unfortunately the api returns Set<String> and sometimes even HashSet<String> or HashMap<String,String>
> I think we should break it and return CharArraySets and CharArrayMaps (but leave the return value as generic Set,Map).
> If someone objects to breaking it in 3.1, then we can do this only in 4.0, but i think it would be good to fix it both places.
> The reason is that if someone does new FooAnalyzer() a lot (probably not uncommon) i think its doing a bunch of useless copying.
> I think we should slap @lucene.internal on this API too, since thats mostly how its being used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org