You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shenyu0127 (via GitHub)" <gi...@apache.org> on 2023/06/14 23:57:26 UTC
[GitHub] [pinot] shenyu0127 opened a new pull request, #10914: Fix the NULL ordering in object single column distinct executors.
shenyu0127 opened a new pull request, #10914:
URL: https://github.com/apache/pinot/pull/10914
Tested in unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] shenyu0127 commented on pull request #10914: Fix the NULL ordering in object single column distinct executors.
Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on PR #10914:
URL: https://github.com/apache/pinot/pull/10914#issuecomment-1601752054
> > Should we consider doing the same trick as primitive data types by tracking a `_hasNull` flag to avoid the extra null handling? That way the behavior is consistent across all data types, and the overall cost should be lower
>
> The `_hasNull` flag is a not a clean solution and we want to avoid if possible.
>
> * The `_hasNull` flag needs to be used for primitive data types because the primitive data type sets/priority_queues cannot store NULL.
> * The `_hasNull` flag has an issue (if there is NULL, it will always be present in the executor result regardless of the ordering) that needs to be fixed in the upstream handling (DistinctTable).
Had an offline chat with @Jackie-Jiang and we aligned to use `_hasNull` mainly for performance (avoid additional null checks in the comparators).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] shenyu0127 commented on pull request #10914: Fix the NULL ordering in object single column distinct executors.
Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on PR #10914:
URL: https://github.com/apache/pinot/pull/10914#issuecomment-1595143454
> Should we consider doing the same trick as primitive data types by tracking a `_hasNull` flag to avoid the extra null handling? That way the behavior is consistent across all data types, and the overall cost should be lower
The `_hasNull` flag is a not a clean solution and we want to avoid if possible.
- The `_hasNull` flag needs to be used for primitive data types because the primitive data type sets/priority_queues cannot store NULL.
- The `_hasNull` flag has an issue (if there is NULL, it will always be present in the executor result regardless of the ordering) that needs to be fixed in the upstream handling (DistinctTable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] shenyu0127 commented on pull request #10914: Use _hasNull in the object single column distinct executors.
Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on PR #10914:
URL: https://github.com/apache/pinot/pull/10914#issuecomment-1603859189
> LGTM! Can you resolve the conflict in the test?
Thank you for the review and approval! Rebased and force-pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10914: Fix the NULL ordering in object single column distinct executors.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10914:
URL: https://github.com/apache/pinot/pull/10914#issuecomment-1592164320
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10914?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10914](https://app.codecov.io/gh/apache/pinot/pull/10914?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d3edd97) into [master](https://app.codecov.io/gh/apache/pinot/commit/90dc3a3c566e5d634aa00632993ab86ce0549ba5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (90dc3a3) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10914 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2188 2134 -54
Lines 117592 115107 -2485
Branches 17768 17474 -294
=========================================
Hits 137 137
+ Misses 117435 114950 -2485
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin20 | `?` | |
| integration2temurin17 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `?` | |
| unittests2temurin17 | `0.11% <0.00%> (-0.01%)` | :arrow_down: |
| unittests2temurin20 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10914?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../raw/BaseRawBytesSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10914?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0J5dGVzU2luZ2xlQ29sdW1uRGlzdGluY3RFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...BigDecimalSingleColumnDistinctOrderByExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10914?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3QmlnRGVjaW1hbFNpbmdsZUNvbHVtbkRpc3RpbmN0T3JkZXJCeUV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../raw/RawBytesSingleColumnDistinctOnlyExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10914?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3Qnl0ZXNTaW5nbGVDb2x1bW5EaXN0aW5jdE9ubHlFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...w/RawBytesSingleColumnDistinctOrderByExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10914?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3Qnl0ZXNTaW5nbGVDb2x1bW5EaXN0aW5jdE9yZGVyQnlFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../RawStringSingleColumnDistinctOrderByExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10914?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3U3RyaW5nU2luZ2xlQ29sdW1uRGlzdGluY3RPcmRlckJ5RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
... and [56 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10914/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10914: Use _hasNull in the object single column distinct executors.
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10914:
URL: https://github.com/apache/pinot/pull/10914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org