[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #5459: [Relay][Op]Support symbolic TopK, Ones, Zeros and Full

[GitBox <gi...@apache.org>]

icemelon9 commented on a change in pull request #5459:
URL: https://github.com/apache/incubator-tvm/pull/5459#discussion_r417073724



##########
File path: include/tvm/relay/attrs/transform.h
##########
@@ -110,7 +110,7 @@ struct TakeAttrs : public tvm::AttrsNode<TakeAttrs> {
 
 /*! \brief Attributes that specify a tensor */
 struct InitOpAttrs : public tvm::AttrsNode<InitOpAttrs> {
-  Array<IndexExpr> shape;
+  Expr shape;

Review comment:
       same here.

##########
File path: include/tvm/relay/attrs/algorithm.h
##########
@@ -50,14 +50,14 @@ struct ArgsortAttrs : public tvm::AttrsNode<ArgsortAttrs> {
 };
 
 struct TopKAttrs : public tvm::AttrsNode<TopKAttrs> {
-  int k;
+  Expr k;

Review comment:
       Should we use `Optional<Integer>` here and it only holds value when input `k` is a constant?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org