[GitHub] spark pull request #11254: [SPARK-13369] Make number of consecutive fetch fa...

[squito <gi...@git.apache.org>]

Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11254#discussion_r106289060
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/Stage.scala ---
    @@ -118,7 +119,7 @@ private[scheduler] abstract class Stage(
        */
       private[scheduler] def failedOnFetchAndShouldAbort(stageAttemptId: Int): Boolean = {
         fetchFailedAttemptIds.add(stageAttemptId)
    -    fetchFailedAttemptIds.size >= Stage.MAX_CONSECUTIVE_FETCH_FAILURES
    +    fetchFailedAttemptIds.size >= maxConsecutiveFetchFailure
    --- End diff --
    
    not a big deal, but since `maxConsecutiveFetchFailure` isn't really changing from stage to stage, so I think rather than making it a member variable of stage, maybe its makes more sense to make it a parameter to this method. thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org