You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 15:49:02 UTC

[GitHub] [arrow] jonkeane commented on a diff in pull request #12928: ARROW-15678: [C++][CI] a crossbow job with MinRelSize enabled

jonkeane commented on code in PR #12928:
URL: https://github.com/apache/arrow/pull/12928#discussion_r854296874


##########
cpp/src/arrow/util/bitmap_writer.h:
##########
@@ -78,96 +79,24 @@ class BitmapWriter {
   int64_t byte_offset_;
 };
 
-class FirstTimeBitmapWriter {
+class ARROW_EXPORT FirstTimeBitmapWriter {

Review Comment:
   This resolved the windows CI failures, though not sure if I should include `ARROW_EXPORT` for other classes as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org