[jira] [Commented] (PHOENIX-1267) Set scan.setSmall(true) when appropriate

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155497#comment-14155497 ] 

James Taylor commented on PHOENIX-1267:
---------------------------------------

This patch is a good start. I'd recommend the following:
- add two new hints: SMALL_SCAN and NO_SMALL_SCAN to the HintNode.Hint enum.
- add a isSmallScan method in QueryPlan and then implement it for the implementors of this interface. This will be similar to what you're doing in your ScanUtil.smallScanForbidden, but in a more structured way. You can get the information directly from the implementors, rather than rely on state from the Scan.
- If the hints contain Hint.SMALL_SCAN, then set small scan to true, if the hints contain Hint.NO_SMALL_SCAN, then set small scan to false. These hints would override the setting of small scan from the above default logic

If you're interested in pursuing this, please let me know [~jaywong].

> Set scan.setSmall(true) when appropriate
> ----------------------------------------
>
>                 Key: PHOENIX-1267
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1267
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>         Attachments: smallscan.patch
>
>
> There's a nice optimization that has been in HBase for a while now to set a scan as "small". This prevents extra RPC calls, I believe. We should add a hint for queries that forces it to be set/not set, and make our best guess on when it should default to true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)