You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2016/09/01 16:36:37 UTC
[GitHub] activemq-artemis pull request #747: ARTEMIS-711 Fix handling of 'bare' heade...
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/747
ARTEMIS-711 Fix handling of 'bare' header
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-711
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/747.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #747
----
commit 46e2197d8b1dab737a3ed0ac41c147bb36e3c99f
Author: jbertram <jb...@apache.org>
Date: 2016-06-13T18:37:24Z
ARTEMIS-711 Fix handling of 'bare' header
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #747: ARTEMIS-711 Fix handling of 'bare' header
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/747
@jbertram checkstyles
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #747: ARTEMIS-711 Fix handling of 'bare' heade...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/747#discussion_r77227583
--- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/util/Wait.java ---
@@ -41,13 +41,13 @@ public static boolean waitFor(final Condition condition, final long duration) th
public static boolean waitFor(final Condition condition,
final long duration,
- final int sleepMillis) throws Exception {
--- End diff --
It's used by org.apache.activemq.artemis.tests.integration.proton.ProtonTestForHeader#testSimpleBytes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #747: ARTEMIS-711 Fix handling of 'bare' heade...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/747
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #747: ARTEMIS-711 Fix handling of 'bare' heade...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/747#discussion_r77226303
--- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/proton/plug/ActiveMQProtonConnectionCallback.java ---
@@ -138,4 +146,8 @@ public AMQPSessionCallback createSessionCallback(AMQPConnectionContext connectio
return new ProtonSessionIntegrationCallback(this, manager, connection, this.connection, closeExecutor);
}
+ @Override
+ public void sendSASLSupported() {
--- End diff --
Is there a link you could add here as a Doc? just for future reference?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #747: ARTEMIS-711 Fix handling of 'bare' heade...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/747#discussion_r77226556
--- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/util/Wait.java ---
@@ -41,13 +41,13 @@ public static boolean waitFor(final Condition condition, final long duration) th
public static boolean waitFor(final Condition condition,
final long duration,
- final int sleepMillis) throws Exception {
--- End diff --
This doesn't seem related?
It's a minor change and I don't mind.. just checking if I'm missing anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---