You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/01 08:07:40 UTC

[GitHub] [hive] miklosgergely commented on a change in pull request #1194: HIVE-23789: Merge ValidTxnManager into DriverTxnHandler (Miklos Gergely)

miklosgergely commented on a change in pull request #1194:
URL: https://github.com/apache/hive/pull/1194#discussion_r448190290



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Compiler.java
##########
@@ -188,7 +188,6 @@ private BaseSemanticAnalyzer analyze() throws Exception {
     // because at that point we need access to the objects.
     Hive.get().getMSC().flushCache();
 
-    driverContext.setBackupContext(new Context(context));

Review comment:
       The usage of backupContext was removed by Peter Varga recently (https://github.com/apache/hive/commit/e2a02f1b43cba657d4d1c16ead091072be5fe834#diff-71a166c053d9c698f9cb64eaef832aff), I've asked him to confirm, and it was intentional. After this change we are only setting the backup context here, but it is never used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org