You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "985492783 (via GitHub)" <gi...@apache.org> on 2023/10/14 16:40:24 UTC
[PR] [ISSUE #7462] remove deprecated LocalTransactionExecuter.java [rocketmq]
985492783 opened a new pull request, #7463:
URL: https://github.com/apache/rocketmq/pull/7463
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7462
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7462] Remove deprecated LocalTransactionExecuter [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #7463:
URL: https://github.com/apache/rocketmq/pull/7463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7462] remove deprecated LocalTransactionExecuter.java [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7463:
URL: https://github.com/apache/rocketmq/pull/7463#issuecomment-1763569318
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7463](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (78e3521) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/2113fa371b9c2bf7c512f8ad234e51c616f1362c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2113fa3) will **increase** coverage by `0.27%`.
> Report is 1 commits behind head on develop.
> The diff coverage is `59.18%`.
```diff
@@ Coverage Diff @@
## develop #7463 +/- ##
=============================================
+ Coverage 42.68% 42.95% +0.27%
- Complexity 9481 9658 +177
=============================================
Files 1150 1161 +11
Lines 82828 83915 +1087
Branches 10772 10898 +126
=============================================
+ Hits 35352 36047 +695
- Misses 43050 43385 +335
- Partials 4426 4483 +57
```
| [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...he/rocketmq/broker/controller/ReplicasManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY29udHJvbGxlci9SZXBsaWNhc01hbmFnZXIuamF2YQ==) | `45.84% <ø> (ø)` | |
| [...mq/broker/offset/RocksDBConsumerOffsetManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvb2Zmc2V0L1JvY2tzREJDb25zdW1lck9mZnNldE1hbmFnZXIuamF2YQ==) | `83.78% <100.00%> (ø)` | |
| [...rocketmq/broker/processor/AckMessageProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0Fja01lc3NhZ2VQcm9jZXNzb3IuamF2YQ==) | `71.51% <100.00%> (ø)` | |
| [...broker/processor/ChangeInvisibleTimeProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0NoYW5nZUludmlzaWJsZVRpbWVQcm9jZXNzb3IuamF2YQ==) | `56.81% <100.00%> (ø)` | |
| [...cketmq/broker/topic/RocksDBTopicConfigManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvdG9waWMvUm9ja3NEQlRvcGljQ29uZmlnTWFuYWdlci5qYXZh) | `78.12% <100.00%> (ø)` | |
| [...he/rocketmq/client/producer/DefaultMQProducer.java](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvcHJvZHVjZXIvRGVmYXVsdE1RUHJvZHVjZXIuamF2YQ==) | `54.34% <ø> (+0.17%)` | :arrow_up: |
| [...ocketmq/client/producer/TransactionMQProducer.java](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvcHJvZHVjZXIvVHJhbnNhY3Rpb25NUVByb2R1Y2VyLmphdmE=) | `55.81% <ø> (+4.75%)` | :arrow_up: |
| [...c/main/java/org/apache/rocketmq/common/MixAll.java](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vTWl4QWxsLmphdmE=) | `38.98% <ø> (ø)` | |
| [...e/rocketmq/common/config/ConfigRocksDBStorage.java](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vY29uZmlnL0NvbmZpZ1JvY2tzREJTdG9yYWdlLmphdmE=) | `0.00% <ø> (ø)` | |
| [...g/apache/rocketmq/common/topic/TopicValidator.java](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdG9waWMvVG9waWNWYWxpZGF0b3IuamF2YQ==) | `96.61% <100.00%> (+0.05%)` | :arrow_up: |
| ... and [39 more](https://app.codecov.io/gh/apache/rocketmq/pull/7463?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7463/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org