You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ya...@apache.org on 2021/08/10 01:59:46 UTC
[incubator-kyuubi] branch master updated: [KYUUBI #905] [MINOR]
clear handleToTSessionHandle in KyuubiOperationManager
This is an automated email from the ASF dual-hosted git repository.
yao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 0f8c70b [KYUUBI #905] [MINOR] clear handleToTSessionHandle in KyuubiOperationManager
0f8c70b is described below
commit 0f8c70b8f116b0b8f7a0d25a6f1e1afb3f700f66
Author: Yue Boyang <bo...@student.unimelb.edu.au>
AuthorDate: Tue Aug 10 09:59:18 2021 +0800
[KYUUBI #905] [MINOR] clear handleToTSessionHandle in KyuubiOperationManager
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
To clear deprecated handleToTSessionHandle in KyuubiOperationManager.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request
Closes #911 from BoyangYue/test-branch.
Closes #905
3da8add4 [Yue Boyang] [KYUUBI #905] [MINOR] clear handleToTSessionHandle in KyuubiOperationManager
Authored-by: Yue Boyang <bo...@student.unimelb.edu.au>
Signed-off-by: Kent Yao <ya...@apache.org>
---
.../scala/org/apache/kyuubi/operation/KyuubiOperationManager.scala | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/operation/KyuubiOperationManager.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/operation/KyuubiOperationManager.scala
index 8b031ff..35d7076 100644
--- a/kyuubi-server/src/main/scala/org/apache/kyuubi/operation/KyuubiOperationManager.scala
+++ b/kyuubi-server/src/main/scala/org/apache/kyuubi/operation/KyuubiOperationManager.scala
@@ -19,7 +19,7 @@ package org.apache.kyuubi.operation
import java.util.concurrent.{ConcurrentHashMap, TimeUnit}
-import org.apache.hive.service.rpc.thrift.{TRowSet, TSessionHandle}
+import org.apache.hive.service.rpc.thrift.TRowSet
import org.apache.kyuubi.KyuubiSQLException
import org.apache.kyuubi.client.KyuubiSyncThriftClient
@@ -34,7 +34,6 @@ class KyuubiOperationManager private (name: String) extends OperationManager(nam
def this() = this(classOf[KyuubiOperationManager].getSimpleName)
private val handleToClient = new ConcurrentHashMap[SessionHandle, KyuubiSyncThriftClient]()
- private val handleToTSessionHandle = new ConcurrentHashMap[SessionHandle, TSessionHandle]()
private var queryTimeout: Option[Long] = None
@@ -68,7 +67,6 @@ class KyuubiOperationManager private (name: String) extends OperationManager(nam
def removeConnection(sessionHandle: SessionHandle): Unit = {
handleToClient.remove(sessionHandle)
- handleToTSessionHandle.remove(sessionHandle)
}
override def newExecuteStatementOperation(