You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by ky...@apache.org on 2019/01/22 12:14:42 UTC

[incubator-weex] branch master updated: [WEEX][Android] Remove Unused PreLoad Statics Method Count Logical (#2069)

This is an automated email from the ASF dual-hosted git repository.

kyork pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git


The following commit(s) were added to refs/heads/master by this push:
     new 8e7e650  [WEEX][Android] Remove Unused PreLoad Statics Method Count Logical (#2069)
8e7e650 is described below

commit 8e7e6505c0e9af4703756fa3c79cf77b8aea4ea2
Author: codefurture <gu...@163.com>
AuthorDate: Tue Jan 22 20:14:38 2019 +0800

    [WEEX][Android] Remove Unused PreLoad Statics Method Count Logical (#2069)
---
 .../com/taobao/weex/ui/WXComponentRegistry.java    |  3 ---
 .../weex/ui/config/AutoScanConfigRegister.java     | 24 ----------------------
 2 files changed, 27 deletions(-)

diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/WXComponentRegistry.java b/android/sdk/src/main/java/com/taobao/weex/ui/WXComponentRegistry.java
index 4465228..9b24933 100644
--- a/android/sdk/src/main/java/com/taobao/weex/ui/WXComponentRegistry.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/WXComponentRegistry.java
@@ -46,9 +46,6 @@ public class WXComponentRegistry {
       return false;
     }
 
-    //register component
-    AutoScanConfigRegister.preLoad(holder);
-
     //execute task in js thread to make sure register order is same as the order invoke register method.
     WXBridgeManager.getInstance()
         .post(new Runnable() {
diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/config/AutoScanConfigRegister.java b/android/sdk/src/main/java/com/taobao/weex/ui/config/AutoScanConfigRegister.java
index fb0a52b..a6cbae0 100644
--- a/android/sdk/src/main/java/com/taobao/weex/ui/config/AutoScanConfigRegister.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/config/AutoScanConfigRegister.java
@@ -44,20 +44,6 @@ public class AutoScanConfigRegister {
 
     public static final  String TAG  = "WeexScanConfigRegister";
 
-    private static ConcurrentLinkedQueue<JavascriptInvokable> autoLoadClass  = new ConcurrentLinkedQueue<>();
-
-    /**
-     * pre load module class and methods when so&jsf init
-     **/
-    public static void preLoad(JavascriptInvokable invokable){
-        if(invokable instanceof ConfigModuleFactory){
-            return;
-        }
-        if(invokable instanceof ConfigComponentHolder){
-            return;
-        }
-        autoLoadClass.add(invokable);
-    }
 
     /**
      * auto scan config files and do auto config from files, none need center register
@@ -80,16 +66,6 @@ public class AutoScanConfigRegister {
             @Override
             public void run() {
                 doScanConfigSync();
-                JavascriptInvokable invokable = autoLoadClass.poll();
-                int count = 0;
-                while (invokable != null){
-                    invokable.getMethods();
-                    invokable = autoLoadClass.poll();
-                    count++;
-                }
-                if(WXEnvironment.isApkDebugable()){
-                    WXLogUtils.d(TAG, "auto preload class's methods count " + count);
-                }
             }
         });
         thread.setName("AutoScanConfigRegister");